[U-Boot] [PATCH v2] ml507: Fix Xilinx uartlite driver hang

The default configuration for ml507 will generate a hang() in the Xilinx uartlite driver.
userial_ports[] in drivers/serial/serial_xuartlite.c does not get initialized properly. CONFIG_SERIAL_BASE is unused. XILINX_UARTLITE_BASEADDR is used instead.
Signed-off-by: Rommel Custodio sessyargc+uboot@gmail.com --- Changes since v1: - fixed the path, tabs got mangled causing the patch to fail
include/configs/xilinx-ppc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/xilinx-ppc.h b/include/configs/xilinx-ppc.h index 1235c37..2bdaa05 100644 --- a/include/configs/xilinx-ppc.h +++ b/include/configs/xilinx-ppc.h @@ -118,7 +118,7 @@ /* serial communication */ #ifdef XPAR_UARTLITE_0_BASEADDR #define CONFIG_XILINX_UARTLITE -#define CONFIG_SERIAL_BASE XPAR_UARTLITE_0_BASEADDR +#define XILINX_UARTLITE_BASEADDR XPAR_UARTLITE_0_BASEADDR #define CONFIG_BAUDRATE XPAR_UARTLITE_0_BAUDRATE #define CONFIG_SYS_BAUDRATE_TABLE { CONFIG_BAUDRATE } #else

Hi,
On Mon, 24 Sep 2012 23:27:05 +0000 (UTC) Rommel Custodio sessyargc+uboot@gmail.com wrote:
The default configuration for ml507 will generate a hang() in the Xilinx uartlite driver.
userial_ports[] in drivers/serial/serial_xuartlite.c does not get initialized properly. CONFIG_SERIAL_BASE is unused. XILINX_UARTLITE_BASEADDR is used instead.
Signed-off-by: Rommel Custodio sessyargc+uboot@gmail.com
Changes since v1:
- fixed the path, tabs got mangled causing the patch to fail
include/configs/xilinx-ppc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/xilinx-ppc.h b/include/configs/xilinx-ppc.h index 1235c37..2bdaa05 100644 --- a/include/configs/xilinx-ppc.h +++ b/include/configs/xilinx-ppc.h @@ -118,7 +118,7 @@ /* serial communication */ #ifdef XPAR_UARTLITE_0_BASEADDR #define CONFIG_XILINX_UARTLITE -#define CONFIG_SERIAL_BASE XPAR_UARTLITE_0_BASEADDR +#define XILINX_UARTLITE_BASEADDR XPAR_UARTLITE_0_BASEADDR #define CONFIG_BAUDRATE XPAR_UARTLITE_0_BAUDRATE #define CONFIG_SYS_BAUDRATE_TABLE { CONFIG_BAUDRATE } #else
I think this patch is correct. Applied to staging/agust@denx.de.
Thanks, Anatolij
participants (2)
-
Anatolij Gustschin
-
Rommel Custodio