[U-Boot] [PATCH] stm32: Correct positioning of declaration

The current code gives a warning:
arch/arm/mach-stm32/stm32f7/soc.c: In function 'arch_cpu_init': arch/arm/mach-stm32/stm32f7/soc.c:38:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode for (int i = 0; i < ARRAY_SIZE(stm32_region_config); i++) ^ arch/arm/mach-stm32/stm32f7/soc.c:38:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
Fix it by moving the declaration to the top of the function.
Signed-off-by: Simon Glass sjg@chromium.org Series-cc trini ---
arch/arm/mach-stm32/stm32f7/soc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-stm32/stm32f7/soc.c b/arch/arm/mach-stm32/stm32f7/soc.c index 74a9350a31..a960cc1cbf 100644 --- a/arch/arm/mach-stm32/stm32f7/soc.c +++ b/arch/arm/mach-stm32/stm32f7/soc.c @@ -17,6 +17,8 @@ u32 get_cpu_rev(void)
int arch_cpu_init(void) { + int i; + struct mpu_region_config stm32_region_config[] = { { 0x00000000, REGION_0, XN_DIS, PRIV_RW_USR_RW, O_I_WB_RD_WR_ALLOC, REGION_4GB }, @@ -35,7 +37,7 @@ int arch_cpu_init(void) };
disable_mpu(); - for (int i = 0; i < ARRAY_SIZE(stm32_region_config); i++) + for (i = 0; i < ARRAY_SIZE(stm32_region_config); i++) mpu_config(&stm32_region_config[i]); enable_mpu();

On Sat, Jul 01, 2017 at 11:06:09AM -0600, Simon Glass wrote:
The current code gives a warning:
arch/arm/mach-stm32/stm32f7/soc.c: In function 'arch_cpu_init': arch/arm/mach-stm32/stm32f7/soc.c:38:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode for (int i = 0; i < ARRAY_SIZE(stm32_region_config); i++) ^ arch/arm/mach-stm32/stm32f7/soc.c:38:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
Fix it by moving the declaration to the top of the function.
Signed-off-by: Simon Glass sjg@chromium.org Series-cc trini
Applied to u-boot/master, thanks!

Thanks Simon,
-----Original Message----- From: Simon Glass [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: Saturday, July 01, 2017 10:06 AM To: U-Boot Mailing List u-boot@lists.denx.de Cc: Simon Glass sjg@chromium.org; Albert Aribaud albert.u.boot@aribaud.net; Toshifumi NISHINAGA tnishinaga.dev@gmail.com; Vikas MANOCHA vikas.manocha@st.com Subject: [PATCH] stm32: Correct positioning of declaration
The current code gives a warning:
arch/arm/mach-stm32/stm32f7/soc.c: In function 'arch_cpu_init': arch/arm/mach-stm32/stm32f7/soc.c:38:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode for (int i = 0; i < ARRAY_SIZE(stm32_region_config); i++) ^ arch/arm/mach-stm32/stm32f7/soc.c:38:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
Fix it by moving the declaration to the top of the function.
Reviewed-by : Vikas MANOCHA vikas.manocha@st.com
Cheers, Vikas
Signed-off-by: Simon Glass sjg@chromium.org Series-cc trini
arch/arm/mach-stm32/stm32f7/soc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-stm32/stm32f7/soc.c b/arch/arm/mach-stm32/stm32f7/soc.c index 74a9350a31..a960cc1cbf 100644 --- a/arch/arm/mach-stm32/stm32f7/soc.c +++ b/arch/arm/mach-stm32/stm32f7/soc.c @@ -17,6 +17,8 @@ u32 get_cpu_rev(void)
int arch_cpu_init(void) {
- int i;
- struct mpu_region_config stm32_region_config[] = { { 0x00000000, REGION_0, XN_DIS, PRIV_RW_USR_RW, O_I_WB_RD_WR_ALLOC, REGION_4GB },
@@ -35,7 +37,7 @@ int arch_cpu_init(void) };
disable_mpu();
- for (int i = 0; i < ARRAY_SIZE(stm32_region_config); i++)
- for (i = 0; i < ARRAY_SIZE(stm32_region_config); i++) mpu_config(&stm32_region_config[i]); enable_mpu();
-- 2.13.2.725.g09c95d1e9-goog
participants (3)
-
Simon Glass
-
Tom Rini
-
Vikas MANOCHA