[U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY reset sequence
Current de-assert reset is not sufficient for the USB PHY reset on some Canyonlands platforms. The patch adds an assert/de-assert sequence. This addresses a USB detection problem for devices attached prior to power-up. The delay lengths are needed for power to the PHY to stabilize.
Signed-off-by: Jeff Mann MannJ@embeddedplanet.com Signed-off-by: Dave Mitchell dmitchell@appliedmicro.com Acked-by: Tirumala Reddy Marri tmarri@appliedmicro.com --- v1->v2: fixed typo
board/amcc/canyonlands/canyonlands.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/board/amcc/canyonlands/canyonlands.c b/board/amcc/canyonlands/canyonlands.c index 13a0dac..6c61122 100644 --- a/board/amcc/canyonlands/canyonlands.c +++ b/board/amcc/canyonlands/canyonlands.c @@ -177,8 +177,11 @@ int board_early_init_f(void) /* Remove NOR-FLASH, NAND-FLASH & EEPROM hardware write protection */ out_8((void *)CONFIG_SYS_BCSR_BASE + 5, 0);
- /* Enable USB host & USB-OTG */ + /* Enable USB host & USB-OTG;force assert,then de-assert PHY reset */ + out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 1); + mdelay(100); out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 0); + mdelay(100);
mtsdr(SDR0_SRST1, 0); /* Pull AHB out of reset default=1 */
Dear Dave Mitchell,
In message 1260824693-11874-1-git-send-email-dmitchell@appliedmicro.com you wrote:
Current de-assert reset is not sufficient for the USB PHY reset on some Canyonlands platforms. The patch adds an assert/de-assert sequence. This addresses a USB detection problem for devices attached prior to power-up. The delay lengths are needed for power to the PHY to stabilize.
Signed-off-by: Jeff Mann MannJ@embeddedplanet.com Signed-off-by: Dave Mitchell dmitchell@appliedmicro.com Acked-by: Tirumala Reddy Marri tmarri@appliedmicro.com
v1->v2: fixed typo
NAK again. This does not belong in generic board init code.
Best regards,
Wolfgang Denk
Hi Wolfgang,
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Monday, December 14, 2009 3:16 PM To: David Mitchell Cc: u-boot@lists.denx.de; Stefan Roese; Jeff Mann Subject: Re: [U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY reset sequence
Dear Dave Mitchell,
In message <1260824693-11874-1-git-send-email- dmitchell@appliedmicro.com> you wrote:
Current de-assert reset is not sufficient for the USB PHY reset on some Canyonlands platforms. The patch adds an assert/de-assert sequence. This addresses a USB detection problem for devices attached prior to power-up. The delay lengths are needed for power to the PHY to stabilize.
Signed-off-by: Jeff Mann MannJ@embeddedplanet.com Signed-off-by: Dave Mitchell dmitchell@appliedmicro.com Acked-by: Tirumala Reddy Marri tmarri@appliedmicro.com
v1->v2: fixed typo
NAK again. This does not belong in generic board init code.
I see. Are you asking that all of the USB code be removed? Including the previous PHY reset implementation done by the original Canyonlands port (toggling the CPLD reset for the PHY).
Best regards, -DM --------------------------------------------------------
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to AppliedMicro Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
Hi Dave,
On Monday 14 December 2009 22:33:56 David Mitchell wrote:
Current de-assert reset is not sufficient for the USB PHY reset on some Canyonlands platforms. The patch adds an assert/de-assert sequence. This addresses a USB detection problem for devices attached prior to power-up. The delay lengths are needed for power to the PHY to stabilize.
Signed-off-by: Jeff Mann MannJ@embeddedplanet.com Signed-off-by: Dave Mitchell dmitchell@appliedmicro.com Acked-by: Tirumala Reddy Marri tmarri@appliedmicro.com
v1->v2: fixed typo
NAK again. This does not belong in generic board init code.
I see. Are you asking that all of the USB code be removed? Including the previous PHY reset implementation done by the original Canyonlands port (toggling the CPLD reset for the PHY).
Yes, it's probably best to move this USB init code to some place that's called in U-Boot only when USB is really used (a board specific USB init function). And we need to add it to the Linux driver(s) as well.
Will you find the time soon to submit such patches?
Thanks.
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
participants (4)
-
Dave Mitchell -
David Mitchell -
Stefan Roese -
Wolfgang Denk