[U-Boot] [PATCH] disk/part.c: fix potential stack overflow bug

If the param pass to get_dev is not the one defined in the block_drvr, it could make uboot becomes unstable, for it would continue run after search complete the block_drvr table.
Signed-off-by: Lei Wen leiwen@marvell.com --- disk/part.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/disk/part.c b/disk/part.c index 13723f2..f07a17f 100644 --- a/disk/part.c +++ b/disk/part.c @@ -84,7 +84,7 @@ block_dev_desc_t *get_dev(char* ifname, int dev) #ifdef CONFIG_NEEDS_MANUAL_RELOC name += gd->reloc_off; #endif - while (name) { + while (drvr->name) { name = drvr->name; reloc_get_dev = drvr->get_dev; #ifdef CONFIG_NEEDS_MANUAL_RELOC

Dear Lei Wen,
In message 1297760200-15301-1-git-send-email-leiwen@marvell.com you wrote:
If the param pass to get_dev is not the one defined in the block_drvr, it could make uboot becomes unstable, for it would continue run after search complete the block_drvr table.
Signed-off-by: Lei Wen leiwen@marvell.com
disk/part.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Lei Wen
-
Wolfgang Denk