[U-Boot] [PATCH 1/1] trace: undefined reference to `trace_early_init'
Compiling with TRACE but without TRACE_EARLY results in an error aarch64-linux-gnu-ld.bfd: common/built-in.o:(.rodata.init_sequence_f+0x10): undefined reference to `trace_early_init'
trace_early_init() should not be called if CONFIG_TRACE_EARLY is not defined.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c index c25eb188fb..0fc938dc87 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -839,7 +839,7 @@ static const init_fnc_t init_sequence_f[] = { #ifdef CONFIG_OF_CONTROL fdtdec_setup, #endif -#ifdef CONFIG_TRACE +#ifdef CONFIG_TRACE_EARLY trace_early_init, #endif initf_malloc, -- 2.20.1
On Sat, 1 Jun 2019 at 23:59, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Compiling with TRACE but without TRACE_EARLY results in an error aarch64-linux-gnu-ld.bfd: common/built-in.o:(.rodata.init_sequence_f+0x10): undefined reference to `trace_early_init'
trace_early_init() should not be called if CONFIG_TRACE_EARLY is not defined.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Sat, 22 Jun 2019 at 13:10, Simon Glass sjg@chromium.org wrote:
On Sat, 1 Jun 2019 at 23:59, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Compiling with TRACE but without TRACE_EARLY results in an error aarch64-linux-gnu-ld.bfd: common/built-in.o:(.rodata.init_sequence_f+0x10): undefined reference to `trace_early_init'
trace_early_init() should not be called if CONFIG_TRACE_EARLY is not defined.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
common/board_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm/next, thanks!
participants (2)
-
Heinrich Schuchardt -
Simon Glass