[U-Boot] [PATCH] powerpc/p2041: fix I2C controller's offset
Without this patch, SPD access will fail which leads to DDR init fail.
Signed-off-by: Shaohui Xie Shaohui.Xie@freescale.com --- include/configs/P2041RDB.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h index 905bacf..862614b 100644 --- a/include/configs/P2041RDB.h +++ b/include/configs/P2041RDB.h @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_SYS_I2C_FSL #define CONFIG_SYS_FSL_I2C_SPEED 400000 #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 +#define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 #define CONFIG_SYS_FSL_I2C2_SPEED 400000 #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C2_OFFSET 0x3100 +#define CONFIG_SYS_FSL_I2C2_OFFSET 0x118100
/* * RapidIO
Hi Xie,
On Tue, Sep 10, 2013 at 8:15 PM, Shaohui Xie Shaohui.Xie@freescale.com wrote:
Without this patch, SPD access will fail which leads to DDR init fail.
Signed-off-by: Shaohui Xie Shaohui.Xie@freescale.com
include/configs/P2041RDB.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h index 905bacf..862614b 100644 --- a/include/configs/P2041RDB.h +++ b/include/configs/P2041RDB.h @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_SYS_I2C_FSL #define CONFIG_SYS_FSL_I2C_SPEED 400000 #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 +#define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 #define CONFIG_SYS_FSL_I2C2_SPEED 400000 #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C2_OFFSET 0x3100 +#define CONFIG_SYS_FSL_I2C2_OFFSET 0x118100
/*
- RapidIO
-- 1.7.0.4
Yes that appears to fix the problem. Thanks for the quick turn around.
Tested-by: Chris Packham judge.packham@gmail.com
On 09/10/2013 02:13 PM, Chris Packham wrote:
Hi Xie,
On Tue, Sep 10, 2013 at 8:15 PM, Shaohui Xie Shaohui.Xie@freescale.com wrote:
Without this patch, SPD access will fail which leads to DDR init fail.
Signed-off-by: Shaohui Xie Shaohui.Xie@freescale.com
include/configs/P2041RDB.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h index 905bacf..862614b 100644 --- a/include/configs/P2041RDB.h +++ b/include/configs/P2041RDB.h @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_SYS_I2C_FSL #define CONFIG_SYS_FSL_I2C_SPEED 400000 #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 +#define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 #define CONFIG_SYS_FSL_I2C2_SPEED 400000 #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C2_OFFSET 0x3100 +#define CONFIG_SYS_FSL_I2C2_OFFSET 0x118100
/*
- RapidIO
-- 1.7.0.4
Yes that appears to fix the problem. Thanks for the quick turn around.
Tested-by: Chris Packham judge.packham@gmail.com
Thanks for the feedback. I will take it in u-boot-mpc85xx.
York
Hello York,
Am 10.09.2013 23:14, schrieb York Sun:
On 09/10/2013 02:13 PM, Chris Packham wrote:
Hi Xie,
On Tue, Sep 10, 2013 at 8:15 PM, Shaohui XieShaohui.Xie@freescale.com wrote:
Without this patch, SPD access will fail which leads to DDR init fail.
Signed-off-by: Shaohui XieShaohui.Xie@freescale.com
include/configs/P2041RDB.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks for this fix!
diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h index 905bacf..862614b 100644 --- a/include/configs/P2041RDB.h +++ b/include/configs/P2041RDB.h @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_SYS_I2C_FSL #define CONFIG_SYS_FSL_I2C_SPEED 400000 #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 +#define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 #define CONFIG_SYS_FSL_I2C2_SPEED 400000 #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F -#define CONFIG_SYS_FSL_I2C2_OFFSET 0x3100 +#define CONFIG_SYS_FSL_I2C2_OFFSET 0x118100
/*
- RapidIO
-- 1.7.0.4
Yes that appears to fix the problem. Thanks for the quick turn around.
Tested-by: Chris Packhamjudge.packham@gmail.com
Thanks for testing.
Thanks for the feedback. I will take it in u-boot-mpc85xx.
Ah, Ok, I am fine with this, so:
Acked-by: Heiko Schocher hs@denx.de
bye, Heiko
participants (4)
-
Chris Packham -
Heiko Schocher -
Shaohui Xie -
York Sun