[U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK board
Hi,
Please find attached a patch applied against the 1.1.1 release.
It fixes some bugs for the Atmel AT91RM9200DK development kit.
- It fixes an Ethernet Initialization problem. Now able to start Linux directly from U-Boot without being forced to perform a tffp command before. - Timings Modifications for SPI DataFlash accesses. - It fixes a NandFlash Detection problem
Tell me if there is something wrong.
Nicolas.
------------------------------------------------------------ LACRESSONNIERE Nicolas
ARM-Based Products Application Group
ATMEL Rousset Zone Industrielle 13106 Rousset Cedex FRANCE Tél: +33 (0)4 42 53 72 54 Fax: +33 (0)4 42 53 60 01 ------------------------------------------------------------
Hello,
in message JPEIKMACJJPLJFDEAJEMKEGDIBAA.nicolas.lacressonniere@rfo.atmel.com you wrote:
- It fixes an Ethernet Initialization problem. Now able to start Linux
directly from U-Boot without being forced to perform a tffp command before.
Rejected.
This is not a problem in U-Boot, but in your Linux driver. The rule is that U-boot will initialize ONLY that hardware which it uses itself, and it may even de-initialize the hardare after use. A Linux driver must not make any assumptions about initialization of the hardware done or not doen in the boot loader. It is resposnible to initialize the hardware to a usable state itself.
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Please split the patch and resubmit only the last 2 items.
In general, please don't combine unrelated modifications in a single patch.
Thanks.
Best regards,
Wolfgang Denk
Hello Wolfgang,
- It fixes an Ethernet Initialization problem. Now able to start Linux
directly from U-Boot without being forced to perform a tffp command
before.
Rejected.
This is not a problem in U-Boot, but in your Linux driver. The rule is that U-boot will initialize ONLY that hardware which it uses itself, and it may even de-initialize the hardare after use. A Linux driver must not make any assumptions about initialization of the hardware done or not doen in the boot loader. It is resposnible to initialize the hardware to a usable state itself.
OK. We will do it differently.
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Please split the patch and resubmit only the last 2 items.
Done.
In general, please don't combine unrelated modifications in a single patch.
Thanks.
Best regards,
Nicolas.
In message JPEIKMACJJPLJFDEAJEMGEGNIBAA.nicolas.lacressonniere@rfo.atmel.com you wrote:
- It fixes an Ethernet Initialization problem. Now able to start Linux
directly from U-Boot without being forced to perform a tffp command
before.
Rejected.
This is not a problem in U-Boot, but in your Linux driver. The rule is that U-boot will initialize ONLY that hardware which it uses itself, and it may even de-initialize the hardare after use. A Linux driver must not make any assumptions about initialization of the hardware done or not doen in the boot loader. It is resposnible to initialize the hardware to a usable state itself.
OK. We will do it differently.
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Please split the patch and resubmit only the last 2 items.
Done.
In general, please don't combine unrelated modifications in a single patch.
Sorry, but I cannot parse this message.
Will you please stick to standard quoting rules?
In this message the text that looks as if it came from you was actually my old message, and I am not sure what you typed new, it anything???
Best regards,
Wolfgang Denk
OK Wolfgang,
Here is the patch containing only both following fixes (Ethernet Initialization removed)
- Timings Modifications for SPI DataFlash accesses. - It fixes a NandFlash Detection problem
Regards.
Nicolas.
-----Original Message----- From: wd@denx.de [mailto:wd@denx.de] Sent: vendredi 25 juin 2004 14:41 To: Nicolas Lacressonniere Cc: u-boot Mailing List; Nicolas Lacressonnière Subject: Re: [U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK board
In message JPEIKMACJJPLJFDEAJEMGEGNIBAA.nicolas.lacressonniere@rfo.atmel.com you wrote:
- It fixes an Ethernet Initialization problem. Now able to start Linux
directly from U-Boot without being forced to perform a tffp command
before.
Rejected.
This is not a problem in U-Boot, but in your Linux driver. The rule is that U-boot will initialize ONLY that hardware which it uses itself, and it may even de-initialize the hardare after use. A Linux driver must not make any assumptions about initialization of the hardware done or not doen in the boot loader. It is resposnible to initialize the hardware to a usable state itself.
OK. We will do it differently.
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Please split the patch and resubmit only the last 2 items.
Done.
In general, please don't combine unrelated modifications in a single patch.
Sorry, but I cannot parse this message.
Will you please stick to standard quoting rules?
In this message the text that looks as if it came from you was actually my old message, and I am not sure what you typed new, it anything???
Best regards,
Wolfgang Denk
-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de The years of peak mental activity are undoubtedly between the ages of four and eighteen. At four we know all the questions, at eighteen all the answers.
In message JPEIKMACJJPLJFDEAJEMMEHAIBAA.nicolas.lacressonniere@rfo.atmel.com you wrote:
Here is the patch containing only both following fixes (Ethernet Initialization removed)
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Submitted (and added) before. Ignored.
Best regards,
Wolfgang Denk
In message JPEIKMACJJPLJFDEAJEMGEGNIBAA.nicolas.lacressonniere@rfo.atmel.com you wrote:
- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem
Added, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Nicolas Lacressonniere -
Wolfgang Denk