[U-Boot] [PATCH] configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx25pdk.h | 2 +- include/configs/mx28evk.h | 2 +- include/configs/mx31pdk.h | 2 +- include/configs/mx35pdk.h | 2 +- include/configs/mx51evk.h | 2 +- include/configs/mx53evk.h | 2 +- include/configs/mx53loco.h | 2 +- include/configs/mx53smd.h | 2 +- include/configs/mx6qarm2.h | 2 +- include/configs/mx6sabre_common.h | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/configs/mx25pdk.h b/include/configs/mx25pdk.h index 543c415..5e89168 100644 --- a/include/configs/mx25pdk.h +++ b/include/configs/mx25pdk.h @@ -65,7 +65,7 @@ #define CONFIG_SYS_MMC_ENV_DEV 0
/* U-Boot general configuration */ -#define CONFIG_SYS_PROMPT "MX25PDK U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ /* Print buffer sz */ diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 07f88ca..fefd499 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -14,7 +14,7 @@ /* System configurations */ #define CONFIG_MX28 /* i.MX28 SoC */ #define CONFIG_MACH_TYPE MACH_TYPE_MX28EVK -#define CONFIG_SYS_PROMPT "MX28EVK U-Boot > " +#define CONFIG_SYS_PROMPT "=> "
/* U-Boot Commands */ #define CONFIG_SYS_NO_FLASH diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h index d41f2cd..72ddab3 100644 --- a/include/configs/mx31pdk.h +++ b/include/configs/mx31pdk.h @@ -120,7 +120,7 @@ * Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ -#define CONFIG_SYS_PROMPT "MX31PDK U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h index 2f59104..59a3798 100644 --- a/include/configs/mx35pdk.h +++ b/include/configs/mx35pdk.h @@ -136,7 +136,7 @@ * Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ -#define CONFIG_SYS_PROMPT "MX35 U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_CMDLINE_EDITING #define CONFIG_SYS_HUSH_PARSER /* Use the HUSH parser */
diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h index 04f518a..fca1f49 100644 --- a/include/configs/mx51evk.h +++ b/include/configs/mx51evk.h @@ -219,7 +219,7 @@ */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ -#define CONFIG_SYS_PROMPT "MX51EVK U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ /* Print Buffer Size */ diff --git a/include/configs/mx53evk.h b/include/configs/mx53evk.h index fe5cf3c..776a26f 100644 --- a/include/configs/mx53evk.h +++ b/include/configs/mx53evk.h @@ -136,7 +136,7 @@ /* Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ -#define CONFIG_SYS_PROMPT "MX53EVK U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h index bd2fa43..d153a4f 100644 --- a/include/configs/mx53loco.h +++ b/include/configs/mx53loco.h @@ -178,7 +178,7 @@ /* Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ -#define CONFIG_SYS_PROMPT "MX53LOCO U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */
diff --git a/include/configs/mx53smd.h b/include/configs/mx53smd.h index 12b2c0d..25ea71c 100644 --- a/include/configs/mx53smd.h +++ b/include/configs/mx53smd.h @@ -121,7 +121,7 @@ /* Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ -#define CONFIG_SYS_PROMPT "MX53SMD U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */
diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h index ef3058c..f44f3b4 100644 --- a/include/configs/mx6qarm2.h +++ b/include/configs/mx6qarm2.h @@ -114,7 +114,7 @@ /* Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP #define CONFIG_SYS_HUSH_PARSER -#define CONFIG_SYS_PROMPT "MX6QARM2 U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h index bf6113b..b0bb02c 100644 --- a/include/configs/mx6sabre_common.h +++ b/include/configs/mx6sabre_common.h @@ -171,7 +171,7 @@ #define CONFIG_SYS_LONGHELP #define CONFIG_SYS_HUSH_PARSER #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT "U-Boot > " +#define CONFIG_SYS_PROMPT "=> " #define CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256
On Thu, Oct 31, 2013 at 2:46 PM, Fabio Estevam fabio.estevam@freescale.com wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Great!
Acked-by: Otavio Salvador otavio@ossystems.com.br
On 31/10/2013 17:46, Fabio Estevam wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
On 10/31/2013 12:08 PM, Stefano Babic wrote:
On 31/10/2013 17:46, Fabio Estevam wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.
Rob
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/31/2013 02:47 PM, Rob Herring wrote:
On 10/31/2013 12:08 PM, Stefano Babic wrote:
On 31/10/2013 17:46, Fabio Estevam wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com ---
Applied to u-boot-imx, thanks !
Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.
Um, yes. Barring urgent bugfixes (which this isn't), can you (Stefano) please wait a day or so between patch posted and merged? That's my rule of thumb. Thanks!
And, Rob's right, we should use his overall patch (and it's on my list, just doing some testing of the Kbuild related things right now).
- -- Tom
Hi Tom,
On 31/10/2013 19:53, Tom Rini wrote:
On 10/31/2013 02:47 PM, Rob Herring wrote:
On 10/31/2013 12:08 PM, Stefano Babic wrote:
On 31/10/2013 17:46, Fabio Estevam wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.
Um, yes. Barring urgent bugfixes (which this isn't), can you (Stefano) please wait a day or so between patch posted and merged? That's my rule of thumb. Thanks!
Sorry, you're right - I will take as lesson to be more patient for the future ;-)
I revert Fabio's patch on u-boot-imx.
Best regards, Stefano Babic
Hi Rob,
On 31/10/2013 19:47, Rob Herring wrote:
On 10/31/2013 12:08 PM, Stefano Babic wrote:
On 31/10/2013 17:46, Fabio Estevam wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
Applied to u-boot-imx, thanks !
Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.
Sorry, you're right. I have quickly estimated Fabio's patch, but again, I had to wait. Sorry for misunderstanding.
I was not aware about your patch, and I agree it should be applied first. I will revert Fabio's patch on u-boot-imx.
Best regards, Stefano Babic
Dear Fabio Estevam,
In message 1383238001-12360-1-git-send-email-fabio.estevam@freescale.com you wrote:
There is no real benefit in adding the board name into U-boot's prompt.
Use the simple "=> " prompt across FSL boards.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
-#define CONFIG_SYS_PROMPT "MX25PDK U-Boot > " +#define CONFIG_SYS_PROMPT "=> "
That's the default prompt, so ther eis no need to define that. Please just remove the existing CONFIG_SYS_PROMPT defines, thanks.
Best regards,
Wolfgang Denk
participants (6)
-
Fabio Estevam -
Otavio Salvador -
Rob Herring -
Stefano Babic -
Tom Rini -
Wolfgang Denk