Re: [PATCH] net: tftp: fix tftp server initialization
On Thu, Mar 31, 2022 at 2:50 PM Arjan Minzinga Zijlstra arjan.minzingazijlstra@fox-it.com wrote:
Some globals where not properly initialized causing timeouts as data packets where not immediately acknowledged.
I don't see a scenario where these two variables will not be initialized. Can you please elaborate ?
These variables are only set on tftp oack packets (which are optional AFAIK) and in the tftp_start() function. However when running the tftpsrv cmd, tftp_start_server() is called, which didn't initialized said variables.
On Mon, Apr 11, 2022 at 2:21 PM Arjan Minzinga Zijlstra arjan.minzingazijlstra@fox-it.com wrote:
On Thu, Mar 31, 2022 at 2:50 PM Arjan Minzinga Zijlstra arjan.minzingazijlstra@fox-it.com wrote:
Some globals where not properly initialized causing timeouts as data packets where not immediately acknowledged.
I don't see a scenario where these two variables will not be initialized. Can you please elaborate ?
These variables are only set on tftp oack packets (which are optional AFAIK) and in the tftp_start() function. However when running the tftpsrv cmd, tftp_start_server() is called, which didn't initialized said variables.
OK. I understand. I'll rework your patch a bit and submit. thanks !
participants (2)
-
Arjan Minzinga Zijlstra -
Ramon Fried