[PATCH] reset: ast2600: Fix missing reference operator

Fix missing reference operator '&' to correctly get HW register addresses for writel().
Signed-off-by: Chia-Wei Wang chiawei_wang@aspeedtech.com --- drivers/reset/reset-ast2600.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/reset/reset-ast2600.c b/drivers/reset/reset-ast2600.c index f64adaf74e..195ddd18e0 100644 --- a/drivers/reset/reset-ast2600.c +++ b/drivers/reset/reset-ast2600.c @@ -41,9 +41,9 @@ static int ast2600_reset_assert(struct reset_ctl *reset_ctl) debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32) - writel(BIT(reset_ctl->id), scu->modrst_ctrl1); + writel(BIT(reset_ctl->id), &scu->modrst_ctrl1); else - writel(BIT(reset_ctl->id - 32), scu->modrst_ctrl2); + writel(BIT(reset_ctl->id - 32), &scu->modrst_ctrl2);
return 0; } @@ -56,9 +56,9 @@ static int ast2600_reset_deassert(struct reset_ctl *reset_ctl) debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32) - writel(BIT(reset_ctl->id), scu->modrst_clr1); + writel(BIT(reset_ctl->id), &scu->modrst_clr1); else - writel(BIT(reset_ctl->id - 32), scu->modrst_clr2); + writel(BIT(reset_ctl->id - 32), &scu->modrst_clr2);
return 0; }

On Tue, Jul 20, 2021 at 03:01:36PM +0800, Chia-Wei Wang wrote:
Fix missing reference operator '&' to correctly get HW register addresses for writel().
Signed-off-by: Chia-Wei Wang chiawei_wang@aspeedtech.com
Applied to u-boot/master, thanks!
participants (2)
-
Chia-Wei Wang
-
Tom Rini