[U-Boot] [PATCH] MPC837XEMDS: fix pci.c build error
Commit 6aa3d3b "83xx: Remove warmboot parameter from PCI init functions" dropped the last argument to mpc83xx_pcie_init(), but failed to fix board/freescale/mpc837xemds/pci.c which resulted in the error:
pci.c: In function 'pci_init_board': pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Kim Phillips kim.phillips@freescale.com
--- board/freescale/mpc837xemds/pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/freescale/mpc837xemds/pci.c b/board/freescale/mpc837xemds/pci.c index 77c5bda..edb3ff0 100644 --- a/board/freescale/mpc837xemds/pci.c +++ b/board/freescale/mpc837xemds/pci.c @@ -138,7 +138,7 @@ skip_pci: out_be32(&pcie_law[1].bar, CONFIG_SYS_PCIE2_BASE & LAWBAR_BAR); out_be32(&pcie_law[1].ar, LBLAWAR_EN | LBLAWAR_512MB);
- mpc83xx_pcie_init(pex2 ? 1 : 2, pcie_reg, 0); + mpc83xx_pcie_init(pex2 ? 1 : 2, pcie_reg); }
void ft_pcie_fixup(void *blob, bd_t *bd)
Hi Wolfgang,
On Sat, 2010-10-16 at 18:07 +0200, Wolfgang Denk wrote:
Commit 6aa3d3b "83xx: Remove warmboot parameter from PCI init functions" dropped the last argument to mpc83xx_pcie_init(), but failed to fix board/freescale/mpc837xemds/pci.c which resulted in the error:
pci.c: In function 'pci_init_board': pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Kim Phillips kim.phillips@freescale.com
I believe Kim already submitted a patch titled "mpc83xx: fix 837x MDS PCI HOST build" to address this issue.
Best, Peter
Dear Peter Tyser,
In message 1287364619.1733.1.camel@ptyser-laptop you wrote:
pci.c: In function 'pci_init_board': pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
...
I believe Kim already submitted a patch titled "mpc83xx: fix 837x MDS PCI HOST build" to address this issue.
Indeed. Thanks for pointing out.
/me wonders why I didn't receive a mpc83xx pull request, then.
Best regards,
Wolfgang Denk
Dear Wolfgang Denk,
In message 1287245275-18900-1-git-send-email-wd@denx.de you wrote:
Commit 6aa3d3b "83xx: Remove warmboot parameter from PCI init functions" dropped the last argument to mpc83xx_pcie_init(), but failed to fix board/freescale/mpc837xemds/pci.c which resulted in the error:
pci.c: In function 'pci_init_board': pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Kim Phillips kim.phillips@freescale.com
board/freescale/mpc837xemds/pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Dumped. Applied Kim's "mpc83xx: fix 837x MDS PCI HOST build" patch instead.
Best regards,
Wolfgang Denk
participants (2)
-
Peter Tyser -
Wolfgang Denk