[U-Boot] [PATCH] corenet: Disable video on P2020DS
The P2020DS build had grown too large, and video support isn't enabled in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com --- include/configs/P2020DS.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/P2020DS.h b/include/configs/P2020DS.h index 0cc5781..a975ee1 100644 --- a/include/configs/P2020DS.h +++ b/include/configs/P2020DS.h @@ -490,7 +490,7 @@ #define VIDEO_IO_OFFSET CONFIG_SYS_PCIE1_IO_VIRT
/* video */ -#define CONFIG_VIDEO +#undef CONFIG_VIDEO
#if defined(CONFIG_VIDEO) #define CONFIG_BIOSEMU
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't enabled in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
On 01/25/2013 12:50:59 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't
enabled
in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There are already 5 P2020DS targets, and there *should* be 8 (why is there no 36BIT version of DDR2, SDCARD, or SPIFLASH?). This would expand it to 16. Ideally we would have something like kconfig, but until then I don't see a reasonable alternative to saying that certain config symbols are user-settable by tweaking the board config file.
-Scott
On 01/25/2013 01:25:33 PM, Scott Wood wrote:
On 01/25/2013 12:50:59 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't
enabled
in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There are already 5 P2020DS targets, and there *should* be 8 (why is there no 36BIT version of DDR2, SDCARD, or SPIFLASH?).
I take that back -- there should be 16, as DDR2 seems to be orthogonal as well. So adding VIDEO on/off for all configs would bring it up to 32 if we fixed the rest.
I suppose you could just have one video config for compilation coverage, but it seems awkward, and what is it really testing? It's not the only board to enable BIOSEMU, ATI framebuffer, etc. You'd just be testing that it works with p2020ds, but for integration testing one config working might not say anything about another.
-Scott
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/25/2013 02:25 PM, Scott Wood wrote:
On 01/25/2013 12:50:59 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't enabled in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There are already 5 P2020DS targets, and there *should* be 8 (why is there no 36BIT version of DDR2, SDCARD, or SPIFLASH?). This would expand it to 16. Ideally we would have something like kconfig, but until then I don't see a reasonable alternative to saying that certain config symbols are user-settable by tweaking the board config file.
That's fine, in general. But does this patch now leave us with non-build testing video code? That way lies bitrot, so yes, please add a 6th target so that when someone needs to hand tweak their P2020DS setup for this, not that, yes this and not that, oh and video, they can have some confidence the code still builds. Or say that P1020/1022 having video on still too means the code in question is still used. That would also be fine. Thanks.
- -- Tom
On Jan 25, 2013, at 12:50 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't enabled in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There doesn't appear to be any 2020-specific code in drivers/video/. The truth is, I doubt the code gets more than compile-tested by the setting being there. Also, as noted, P1022 defines it, in addition to MPC8536, MPC8544, MPC8572, MPC8610, and MPC8641. I'd rather not hack up a "video" config just for P2020, if possible.
Andy
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/25/2013 03:43 PM, Fleming Andy-AFLEMING wrote:
On Jan 25, 2013, at 12:50 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't enabled in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There doesn't appear to be any 2020-specific code in drivers/video/. The truth is, I doubt the code gets more than compile-tested by the setting being there. Also, as noted, P1022 defines it, in addition to MPC8536, MPC8544, MPC8572, MPC8610, and MPC8641. I'd rather not hack up a "video" config just for P2020, if possible.
That's all I was looking for, that yes, we don't now have very dead code there. Thanks! (and I kicked off my loop of testing on the PR that includes this change a while ago, still spinning over everything).
- -- Tom
participants (4)
-
Andy Fleming -
Fleming Andy-AFLEMING
-
Scott Wood -
Tom Rini