[PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com --- drivers/clk/clk-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 9aa8537004..170e19db65 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -326,7 +326,6 @@ int clk_set_defaults(struct udevice *dev, int stage)
return 0; } -# endif /* OF_PLATDATA */
int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk) { @@ -343,6 +342,7 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
return clk_get_by_index(dev, index, clk); } +# endif /* OF_PLATDATA */
int clk_release_all(struct clk *clk, int count) {
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Kind regards
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
Kind regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
This is a standalone fix.
Best regards
On Fri, 13 Dec 2019 12:38:43 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
This is a standalone fix.
Ok. Thanks for preparing it.
Best regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi Giulio,
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
This is a standalone fix.
As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.
Do you mind ?
Best regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi Lukasz,
On 12/15/19 2:50 PM, Lukasz Majewski wrote:
Hi Giulio,
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
This is a standalone fix.
As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.
Do you mind ?
No problem at all, we'll see it "next"!
Best regards
Hi Lukasz,
On 12/15/19 4:09 PM, Giulio Benetti wrote:
Hi Lukasz,
On 12/15/19 2:50 PM, Lukasz Majewski wrote:
Hi Giulio,
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
On Fri, 13 Dec 2019 00:02:25 +0100 Giulio Benetti giulio.benetti@benettiengineering.com wrote:
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
clk_get_by_name() requires clk_get_by_id() that is not available if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com
I've already successfully executed a complete Travis with master and this patch applied: https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a standalone fix?
This is a standalone fix.
As we are really close to final U-Boot release - I'm more keen to add this patch to u-boot-clk -next repository.
Do you mind ?
No problem at all, we'll see it "next"!
Best regards
Kindly ping
Best regards
participants (2)
-
Giulio Benetti -
Lukasz Majewski