Re: [U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x
Stefan:
Please give the attached version a try and let me know if it works for
you. If nobody objects this will go into the official tree soon.
It looks good, but I see one minor problem: in nand_init(...) in drivers/nand/nand.c, nand_curr_device is set to the first nand device that is found. In the nand flash controller driver board_nand_init(...), the chip select is set. So after two or more devices are found, the chip select is left set to the last device while nand_curr_device is set for the first. A call to board_nand_select_device(...) is needed at the end of nand_init(...) to set the chip selects correctly.
-Jeff
Hi Jeff,
On Wednesday 18 October 2006 23:38, Jeff Mann wrote:
It looks good, but I see one minor problem: in nand_init(...) in drivers/nand/nand.c, nand_curr_device is set to the first nand device that is found. In the nand flash controller driver board_nand_init(...), the chip select is set. So after two or more devices are found, the chip select is left set to the last device while nand_curr_device is set for the first. A call to board_nand_select_device(...) is needed at the end of nand_init(...) to set the chip selects correctly.
Yes, I overlooked this. Thanks. I'll update the code and commit in the next few days.
Best regards, Stefan
On Friday 20 October 2006 14:23, Stefan Roese wrote:
Yes, I overlooked this. Thanks. I'll update the code and commit in the next few days.
Applied. Thanks.
Best regards, Stefan
participants (2)
-
Jeff Mann -
Stefan Roese