[U-Boot] [PATCH 0/3] Minor cm-t35/cm-t3730 updates

This patch series makes minor adjustments to the cm-t35/cm-t3730 board code.
Igor Grinberg (3): omap3: Kconfig: fix the cm-t35 board option prompt omap3: cm-t35: use define for mmc wp gpio omap3: cm-t35: remove enable_gpmc_cs_config()
arch/arm/cpu/armv7/omap3/Kconfig | 2 +- board/compulab/cm_t35/cm_t35.c | 17 +++-------------- 2 files changed, 4 insertions(+), 15 deletions(-)

The cm-t35 board support covers both cm-t3530 and cm-t3730 boards. Mention both boards in the Kconfig option prompt.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- arch/arm/cpu/armv7/omap3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/omap3/Kconfig b/arch/arm/cpu/armv7/omap3/Kconfig index 6fae1e5..4a48f84 100644 --- a/arch/arm/cpu/armv7/omap3/Kconfig +++ b/arch/arm/cpu/armv7/omap3/Kconfig @@ -16,7 +16,7 @@ config TARGET_OMAP3_BEAGLE bool "TI OMAP3 BeagleBoard"
config TARGET_CM_T35 - bool "CompuLab CM-T35" + bool "CompuLab CM-T3530 and CM-T3730 boards"
config TARGET_DEVKIT8000 bool "TimLL OMAP3 Devkit8000"

On Tue, Oct 21, 2014 at 04:39:45PM +0300, Igor Grinberg wrote:
The cm-t35 board support covers both cm-t3530 and cm-t3730 boards. Mention both boards in the Kconfig option prompt.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot-ti/master, thanks!

Switch to using define for MMC WP GPIO instead of a magic number.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- board/compulab/cm_t35/cm_t35.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c index 0944903..6728ac1 100644 --- a/board/compulab/cm_t35/cm_t35.c +++ b/board/compulab/cm_t35/cm_t35.c @@ -457,6 +457,8 @@ void set_muxconf_regs(void) }
#if defined(CONFIG_GENERIC_MMC) && !defined(CONFIG_SPL_BUILD) +#define SB_T35_WP_GPIO 59 + int board_mmc_getcd(struct mmc *mmc) { u8 val; @@ -469,7 +471,7 @@ int board_mmc_getcd(struct mmc *mmc)
int board_mmc_init(bd_t *bis) { - return omap_mmc_init(0, 0, 0, -1, 59); + return omap_mmc_init(0, 0, 0, -1, SB_T35_WP_GPIO); } #endif

On Tue, Oct 21, 2014 at 04:39:46PM +0300, Igor Grinberg wrote:
Switch to using define for MMC WP GPIO instead of a magic number.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot-ti/master, thanks!

The gpmc_init() function already calls enable_gpmc_cs_config() for chip select 0. Although the bus width is configured for 16 bit, it gets reconfigured correctly in the omap_gpmc driver later.
Remove the enable_gpmc_cs_config() function call and the associated gpmc_nand_config[] array.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- board/compulab/cm_t35/cm_t35.c | 13 ------------- 1 file changed, 13 deletions(-)
diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c index 6728ac1..f8265e1 100644 --- a/board/compulab/cm_t35/cm_t35.c +++ b/board/compulab/cm_t35/cm_t35.c @@ -53,16 +53,6 @@ static u32 gpmc_net_config[GPMC_MAX_REG] = { 0 };
-static u32 gpmc_nand_config[GPMC_MAX_REG] = { - M_NAND_GPMC_CONFIG1, - M_NAND_GPMC_CONFIG2, - M_NAND_GPMC_CONFIG3, - M_NAND_GPMC_CONFIG4, - M_NAND_GPMC_CONFIG5, - M_NAND_GPMC_CONFIG6, - 0, -}; - #ifdef CONFIG_LCD #ifdef CONFIG_CMD_NAND static int splash_load_from_nand(u32 bmp_load_addr) @@ -148,9 +138,6 @@ int board_init(void) { gpmc_init(); /* in SRAM or SDRAM, finish GPMC */
- enable_gpmc_cs_config(gpmc_nand_config, &gpmc_cfg->cs[0], - CONFIG_SYS_NAND_BASE, GPMC_SIZE_16M); - /* board id for Linux */ if (get_cpu_family() == CPU_OMAP34XX) gd->bd->bi_arch_number = MACH_TYPE_CM_T35;

On Tue, Oct 21, 2014 at 04:39:47PM +0300, Igor Grinberg wrote:
The gpmc_init() function already calls enable_gpmc_cs_config() for chip select 0. Although the bus width is configured for 16 bit, it gets reconfigured correctly in the omap_gpmc driver later.
Remove the enable_gpmc_cs_config() function call and the associated gpmc_nand_config[] array.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot-ti/master, thanks!
participants (2)
-
Igor Grinberg
-
Tom Rini