[U-Boot] [PATCH 1/1] efi_selftest: do not use efi_free_pool()

In efi_selftest we are in EFI land. We should not use U-Boot library functions but boot time services for memory management.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- lib/efi_selftest/efi_selftest_block_device.c | 2 +- lib/efi_selftest/efi_selftest_startimage_exit.c | 2 +- lib/efi_selftest/efi_selftest_startimage_return.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/efi_selftest/efi_selftest_block_device.c b/lib/efi_selftest/efi_selftest_block_device.c index 1cdd8307f4..21409aed6f 100644 --- a/lib/efi_selftest/efi_selftest_block_device.c +++ b/lib/efi_selftest/efi_selftest_block_device.c @@ -264,7 +264,7 @@ static int teardown(void) }
if (image) { - r = efi_free_pool(image); + r = boottime->free_pool(image); if (r != EFI_SUCCESS) { efi_st_error("Failed to free image\n"); return EFI_ST_FAILURE; diff --git a/lib/efi_selftest/efi_selftest_startimage_exit.c b/lib/efi_selftest/efi_selftest_startimage_exit.c index 0d9e16437a..fa4b7d4a9b 100644 --- a/lib/efi_selftest/efi_selftest_startimage_exit.c +++ b/lib/efi_selftest/efi_selftest_startimage_exit.c @@ -103,7 +103,7 @@ static int teardown(void) efi_status_t r = EFI_ST_SUCCESS;
if (image) { - r = efi_free_pool(image); + r = boottime->free_pool(image); if (r != EFI_SUCCESS) { efi_st_error("Failed to free image\n"); return EFI_ST_FAILURE; diff --git a/lib/efi_selftest/efi_selftest_startimage_return.c b/lib/efi_selftest/efi_selftest_startimage_return.c index 3c6249fdf1..fabf53d983 100644 --- a/lib/efi_selftest/efi_selftest_startimage_return.c +++ b/lib/efi_selftest/efi_selftest_startimage_return.c @@ -103,7 +103,7 @@ static int teardown(void) efi_status_t r = EFI_ST_SUCCESS;
if (image) { - r = efi_free_pool(image); + r = boottime->free_pool(image); if (r != EFI_SUCCESS) { efi_st_error("Failed to free image\n"); return EFI_ST_FAILURE;

On 12.02.19 22:02, Heinrich Schuchardt wrote:
In efi_selftest we are in EFI land. We should not use U-Boot library functions but boot time services for memory management.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Reviewed-by: Alexander Graf agraf@suse.de
Alex
participants (2)
-
Alexander Graf
-
Heinrich Schuchardt