Re: [U-Boot] [PATCH 1/6 V4] EXYNOS5: Fix system register structure
Hi Marek,
On Wed, May 14, 2012 at 11:56 PM, Marek Vasut <marex@denx.dechander.kashyap@linaro.org
wrote:
Dear Rajeshwari Shinde,
This patch corrects the SYSREG structure.
What is the exact difference between this patchset and V3 one? It's a good practice to sum such things up below diffstat.
Yes, Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI, and mentioned in the same.
We have removed the sysreg.h added in the previous patchset version as the sysreg structure is already defined in system.h.
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
arch/arm/include/asm/arch-exynos/system.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -42,6 +42,7 @@ struct exynos5_sysreg { unsigned int reserved; unsigned int ispblk_cfg; unsigned int usb20phy_cfg;
unsigned char res2[0x29c]; unsigned int mipi_dphy; unsigned int dptx_dphy; unsigned int phyclk_sel;Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- with warm regards, Chander Kashyap
Best regards Vivek Gautam
Dear Vivek Gautam,
Hi Marek,
On Wed, May 14, 2012 at 11:56 PM, Marek Vasut <marex@denx.dechander.kashyap@linaro.org
wrote:
Dear Rajeshwari Shinde,
This patch corrects the SYSREG structure.
What is the exact difference between this patchset and V3 one? It's a good practice to sum such things up below diffstat.
Yes, Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI, and mentioned in the same.
What exact change please?
We have removed the sysreg.h added in the previous patchset version as the sysreg structure is already defined in system.h.
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
arch/arm/include/asm/arch-exynos/system.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -42,6 +42,7 @@ struct exynos5_sysreg {
unsigned int reserved; unsigned int ispblk_cfg; unsigned int usb20phy_cfg;
unsigned char res2[0x29c]; unsigned int mipi_dphy; unsigned int dptx_dphy; unsigned int phyclk_sel;Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- with warm regards, Chander Kashyap
Best regards Vivek Gautam
Best regards, Marek Vasut
Hi Marek,
The exact change is in "[PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI", It is : Renamed exynos5_set_usb_phy_ctrl and set_usb_phy_ctrl to exynos5_set_usbhost_phy_ctrl and set_usbhost_phy_ctrl.
On Wed, May 16, 2012 at 6:53 PM, Marek Vasut marex@denx.de wrote:
Dear Vivek Gautam,
Hi Marek,
On Wed, May 14, 2012 at 11:56 PM, Marek Vasut <marex@denx.dechander.kashyap@linaro.org
wrote:
Dear Rajeshwari Shinde,
This patch corrects the SYSREG structure.
What is the exact difference between this patchset and V3 one? It's a good practice to sum such things up below diffstat.
Yes, Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI, and mentioned in the same.
What exact change please?
We have removed the sysreg.h added in the previous patchset version as the sysreg structure is already defined in system.h.
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
arch/arm/include/asm/arch-exynos/system.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -42,6 +42,7 @@ struct exynos5_sysreg {
unsigned int reserved; unsigned int ispblk_cfg; unsigned int usb20phy_cfg;
- unsigned char res2[0x29c];
unsigned int mipi_dphy; unsigned int dptx_dphy; unsigned int phyclk_sel;
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- with warm regards, Chander Kashyap
Best regards Vivek Gautam
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Regards, Rajeshwari Shinde.
Dear Rajeshwari Birje,
Hi Marek,
The exact change is in "[PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI", It is : Renamed exynos5_set_usb_phy_ctrl and set_usb_phy_ctrl to exynos5_set_usbhost_phy_ctrl and set_usbhost_phy_ctrl.
Thank you for clearing this up. I'm now waiting for pullrq from albert to hit mainline.
On Wed, May 16, 2012 at 6:53 PM, Marek Vasut marex@denx.de wrote:
Dear Vivek Gautam,
Hi Marek,
On Wed, May 14, 2012 at 11:56 PM, Marek Vasut <marex@denx.dechander.kashyap@linaro.org
wrote:
Dear Rajeshwari Shinde,
This patch corrects the SYSREG structure.
What is the exact difference between this patchset and V3 one? It's a good practice to sum such things up below diffstat.
Yes, Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI, and mentioned in the same.
What exact change please?
We have removed the sysreg.h added in the previous patchset version as the sysreg structure is already defined in system.h.
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
arch/arm/include/asm/arch-exynos/system.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -42,6 +42,7 @@ struct exynos5_sysreg {
unsigned int reserved; unsigned int ispblk_cfg; unsigned int usb20phy_cfg;
unsigned char res2[0x29c]; unsigned int mipi_dphy; unsigned int dptx_dphy; unsigned int phyclk_sel;Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- with warm regards, Chander Kashyap
Best regards Vivek Gautam
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Regards, Rajeshwari Shinde.
Best regards, Marek Vasut
participants (3)
-
Marek Vasut -
Rajeshwari Birje -
Vivek Gautam