[U-Boot] [PATCH] env: fix cmd_env_sub fct pointers if CONFIG_RELOC_FIXUP_WORKS is not defined

commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces a command_sub_table for the "env" command. On arm, avr32, m68k, mips and sparc architectures, relocation needs manual fixups, so add these fixups for this sub command table too.
Tested on arm/qong board. mips board (Ben NanoNote) from Xiangfu Liu arm/AT91 board from Reinhard Meyer
Signed-off-by: Heiko Schocher hs@denx.de
cc: Wolfgang Denk wd@denx.de cc: Shinya Kuribayashi skuribay@ruby.dti.ne.jp cc: Xiangfu Liu xiangfu@openmobilefree.net cc: Reinhard Meyer u-boot@emk-elektronik.de --- common/cmd_nvedit.c | 6 ++++++ common/env_common.c | 5 +++++ 2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index c3d63b8..16f5fb0 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -837,6 +837,12 @@ static cmd_tbl_t cmd_env_sub[] = { U_BOOT_CMD_MKENT(set, CONFIG_SYS_MAXARGS, 0, do_env_set, "", ""), };
+#if !defined(CONFIG_RELOC_FIXUP_WORKS) +void env_reloc(void) { + fixup_cmdtable(cmd_env_sub, ARRAY_SIZE(cmd_env_sub)); +} +#endif + static int do_env (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { cmd_tbl_t *cp; diff --git a/common/env_common.c b/common/env_common.c index a415ef8..88f068c 100644 --- a/common/env_common.c +++ b/common/env_common.c @@ -227,6 +227,11 @@ int env_import(const char *buf, int check)
void env_relocate (void) { +#if !defined(CONFIG_RELOC_FIXUP_WORKS) + extern void env_reloc(void); + + env_reloc(); +#endif if (gd->env_valid == 0) { #if defined(CONFIG_ENV_IS_NOWHERE) /* Environment not changable */ set_default_env(NULL);

Hello.
On 05-10-2010 9:41, Heiko Schocher wrote:
commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces a command_sub_table for the "env" command. On arm, avr32, m68k, mips and sparc architectures, relocation needs manual fixups, so add these fixups for this sub command table too.
Tested on arm/qong board. mips board (Ben NanoNote) from Xiangfu Liu arm/AT91 board from Reinhard Meyer
Signed-off-by: Heiko Schocherhs@denx.de
[...]
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index c3d63b8..16f5fb0 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -837,6 +837,12 @@ static cmd_tbl_t cmd_env_sub[] = { U_BOOT_CMD_MKENT(set, CONFIG_SYS_MAXARGS, 0, do_env_set, "", ""), };
+#if !defined(CONFIG_RELOC_FIXUP_WORKS) +void env_reloc(void) {
{ should be on a separate line.
WBR, Sergei

commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces a command_sub_table for the "env" command. On arm, avr32, m68k, mips and sparc architectures, relocation needs manual fixups, so add these fixups for this sub command table too.
Tested on arm/qong board. mips board (Ben NanoNote) from Xiangfu Liu arm/AT91 board from Reinhard Meyer
Signed-off-by: Heiko Schocher hs@denx.de
cc: Wolfgang Denk wd@denx.de cc: Shinya Kuribayashi skuribay@ruby.dti.ne.jp cc: Xiangfu Liu xiangfu@openmobilefree.net cc: Reinhard Meyer u-boot@emk-elektronik.de cc: sshtylyov@mvista.com --- - changes since v1: fix Coding Style issue, suggested by Sergei Shtylyov
common/cmd_nvedit.c | 7 +++++++ common/env_common.c | 5 +++++ 2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index c3d63b8..3d30c32 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -837,6 +837,13 @@ static cmd_tbl_t cmd_env_sub[] = { U_BOOT_CMD_MKENT(set, CONFIG_SYS_MAXARGS, 0, do_env_set, "", ""), };
+#if !defined(CONFIG_RELOC_FIXUP_WORKS) +void env_reloc(void) +{ + fixup_cmdtable(cmd_env_sub, ARRAY_SIZE(cmd_env_sub)); +} +#endif + static int do_env (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { cmd_tbl_t *cp; diff --git a/common/env_common.c b/common/env_common.c index a415ef8..88f068c 100644 --- a/common/env_common.c +++ b/common/env_common.c @@ -227,6 +227,11 @@ int env_import(const char *buf, int check)
void env_relocate (void) { +#if !defined(CONFIG_RELOC_FIXUP_WORKS) + extern void env_reloc(void); + + env_reloc(); +#endif if (gd->env_valid == 0) { #if defined(CONFIG_ENV_IS_NOWHERE) /* Environment not changable */ set_default_env(NULL);

Dear Heiko Schocher,
In message 1286281020-21895-1-git-send-email-hs@denx.de you wrote:
commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces a command_sub_table for the "env" command. On arm, avr32, m68k, mips and sparc architectures, relocation needs manual fixups, so add these fixups for this sub command table too.
Tested on arm/qong board. mips board (Ben NanoNote) from Xiangfu Liu arm/AT91 board from Reinhard Meyer
Signed-off-by: Heiko Schocher hs@denx.de
cc: Wolfgang Denk wd@denx.de cc: Shinya Kuribayashi skuribay@ruby.dti.ne.jp cc: Xiangfu Liu xiangfu@openmobilefree.net cc: Reinhard Meyer u-boot@emk-elektronik.de cc: sshtylyov@mvista.com
- changes since v1: fix Coding Style issue, suggested by Sergei Shtylyov
common/cmd_nvedit.c | 7 +++++++ common/env_common.c | 5 +++++ 2 files changed, 12 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Heiko Schocher
-
Sergei Shtylyov
-
Wolfgang Denk