[U-Boot] [RESEND PATCH] Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.
The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.
The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.
Signed-off-by: Vagrant Cascadian vagrant@debian.org ---
include/configs/odroid_xu3.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index 9898c42b8e..f495f6219b 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -101,7 +101,6 @@ EXYNOS_FDTFILE_SETTING \ MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \ - "bootdelay=0\0" \ "rootfstype=ext4\0" \ "console=" CONFIG_DEFAULT_CONSOLE "\0"\ "fdtfile=exynos5422-odroidxu3.dtb\0" \
On 06/03/2018 08:56 PM, Vagrant Cascadian wrote:
The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.
The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.
Signed-off-by: Vagrant Cascadian vagrant@debian.org
We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.
Acked-by: Heinrich Schuchardt xypron.glpk@gmx.de
@Tom: As Jaehoon did not find time for reviewing since March, would you pick up the patch?
include/configs/odroid_xu3.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index 9898c42b8e..f495f6219b 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -101,7 +101,6 @@ EXYNOS_FDTFILE_SETTING \ MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \
- "bootdelay=0\0" \ "rootfstype=ext4\0" \ "console=" CONFIG_DEFAULT_CONSOLE "\0"\ "fdtfile=exynos5422-odroidxu3.dtb\0" \
On 06/03/2018 11:23 PM, Heinrich Schuchardt wrote:
On 06/03/2018 08:56 PM, Vagrant Cascadian wrote:
The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.
The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.
Signed-off-by: Vagrant Cascadian vagrant@debian.org
We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.
Acked-by: Heinrich Schuchardt xypron.glpk@gmx.de
@Tom: As Jaehoon did not find time for reviewing since March, would you pick up the patch?
Acked-by: Marek Vasut marex@denx.de
On Sun, Jun 03, 2018 at 11:23:07PM +0200, Heinrich Schuchardt wrote:
On 06/03/2018 08:56 PM, Vagrant Cascadian wrote:
The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.
The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.
Signed-off-by: Vagrant Cascadian vagrant@debian.org
We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.
Acked-by: Heinrich Schuchardt xypron.glpk@gmx.de
@Tom: As Jaehoon did not find time for reviewing since March, would you pick up the patch?
OK, I'll pick it up, thanks guys!
On Sun, Jun 03, 2018 at 11:56:05AM -0700, Vagrant Cascadian wrote:
The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.
The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.
Signed-off-by: Vagrant Cascadian vagrant@debian.org Acked-by: Heinrich Schuchardt xypron.glpk@gmx.de Acked-by: Marek Vasut marex@denx.de
Applied to u-boot/master, thanks!
participants (4)
-
Heinrich Schuchardt -
Marek Vasut -
Tom Rini -
Vagrant Cascadian