Avoid an endless loop in add_strings_package().

Suggested-by: Takahiro Akashi takahiro.akashi@linaro.org Reported-by: Coverity (CID 185833) Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- v2 change commit message to show Reported-by: Coverity --- lib/efi_loader/efi_hii.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c index 3a966fa4dff..61b71dec621 100644 --- a/lib/efi_loader/efi_hii.c +++ b/lib/efi_loader/efi_hii.c @@ -227,9 +227,8 @@ out: error: if (stbl) { free(stbl->language); - if (idx > 0) - while (--idx >= 0) - free(stbl->strings[idx].string); + while (idx > 0) + free(stbl->strings[--idx].string); free(stbl->strings); } free(stbl); -- 2.20.1