[U-Boot] Many unused variable warnings
Hi.
The recent GCC versions catch unused variables.
This makes build testing noisy.
Of course, we could use old GCC when running Buildman, but it would be nicer to eliminate the root causes.
I got the following when I recently ran Buildman with arm/aarch64 GCC 6.1.
drivers/usb/gadget/dwc2_udc_otg.c was fixed lately, but there are still many warnings to be fixed.
Board maintainers, please check your own boards. Or, somebody who volunteers to fix them? Thanks!
w+../arch/arm/cpu/arm926ejs/mxs/spl_boot.c:44:26: warning: 'iomux_boot' defined but not used [-Wunused-const-variable=] w+../common/cli_readline.c:20:21: warning: 'tab_seq' defined but not used [-Wunused-const-variable=] w+../common/cli_readline.c:19:19: warning: 'erase_seq' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/dwc2_udc_otg.c:72:19: warning: 'driver_desc' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap4/hw_data.c:136:3: warning: 'abe_dpll_params_sysclk_196608khz' defined but not used [-Wunused-const-variable=] w+../drivers/clk/rockchip/clk_rk3288.c:135:29: warning: 'cpll_init_cfg' defined but not used [-Wunused-const-variable=] w+../drivers/clk/rockchip/clk_rk3288.c:134:29: warning: 'gpll_init_cfg' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:226:33: warning: 'dual_0S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:213:33: warning: 'dual_S0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:196:33: warning: 'dual_0D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:179:33: warning: 'dual_D0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:162:33: warning: 'dual_SS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:140:33: warning: 'dual_SD' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:119:33: warning: 'dual_DS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:92:33: warning: 'dual_DD' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/ether.c:501:17: warning: 'mdlm_detail_desc' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:80:33: warning: 'single_S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:63:33: warning: 'single_D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:36:33: warning: 'single_Q' defined but not used [-Wunused-const-variable=] w+../board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c:228:29: warning: 'usdhc1_pads' defined but not used [-Wunused-const-variable=] w+../drivers/net/eepro100.c:210:19: warning: 'i82557_config_cmd' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:456:33: warning: 'dual_0S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:443:33: warning: 'dual_S0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:426:33: warning: 'dual_0D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:409:33: warning: 'dual_D0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:392:33: warning: 'dual_SS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:370:33: warning: 'dual_SD' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:349:33: warning: 'dual_DS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:322:33: warning: 'dual_DD' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:204:33: warning: 'abe_dpll_params_32k_196608khz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:131:4: warning: 'core_dpll_params_2128mhz_ddr266_es2' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:120:4: warning: 'core_dpll_params_2128mhz_ddr266' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:65:33: warning: 'mpu_dpll_params_499mhz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:54:33: warning: 'mpu_dpll_params_400mhz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:32:33: warning: 'mpu_dpll_params_1_5ghz' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:136:29: warning: 'gpios_pads' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:171:29: warning: 'usdhc4_pads' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:112:29: warning: 'nfc_pads' defined but not used [-Wunused-const-variable=] w+../board/bachmann/ot1200/ot1200.c:276:29: warning: 'pwm_pad' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:193:3: warning: 'abe_dpll_params_sysclk_196608khz' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:69:28: warning: 'SEQ_SLPIN' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:49:28: warning: 'SEQ_APON' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:25:28: warning: 'SEQ_TEMP_SWIRE' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:13:28: warning: 'SEQ_SWRESET' defined but not used [-Wunused-const-variable=] w+../board/toradex/colibri_imx7/colibri_imx7.c:101:29: warning: 'usdhc3_emmc_pads' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-rockchip/rk3036-board-spl.c:19:34: warning: 'grf' defined but not used [-Wunused-const-variable=] w+../board/congatec/cgtqmx6eval/cgtqmx6eval.c:84:29: warning: 'usdhc3_pads' defined but not used [-Wunused-const-variable=] w+../board/congatec/cgtqmx6eval/cgtqmx6eval.c:74:29: warning: 'usdhc2_pads' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/at91_udc.c:1506:35: warning: 'at91sam9263_udc_caps' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/at91_udc.c:1389:35: warning: 'at91rm9200_udc_caps' defined but not used [-Wunused-const-variable=] w+../board/gateworks/gw_ventana/common.c:140:29: warning: 'gwproto_gpio_pads' defined but not used [-Wunused-const-variable=]
On Thu, Dec 15, 2016 at 12:55:36PM +0900, Masahiro Yamada wrote:
Hi.
The recent GCC versions catch unused variables.
This makes build testing noisy.
Of course, we could use old GCC when running Buildman, but it would be nicer to eliminate the root causes.
I got the following when I recently ran Buildman with arm/aarch64 GCC 6.1.
What's more worrying to me is that we need to adapt our RSA using code for openssl 1.1 which is the default in debian/unstable, which is the easiest way to get gcc 6.1 toolchains. I might take a quick stab at fixing some of the warnings, thanks for the reminder!
On 12/15/2016 04:55 AM, Masahiro Yamada wrote:
Hi.
The recent GCC versions catch unused variables.
This makes build testing noisy.
Of course, we could use old GCC when running Buildman, but it would be nicer to eliminate the root causes.
I got the following when I recently ran Buildman with arm/aarch64 GCC 6.1.
drivers/usb/gadget/dwc2_udc_otg.c was fixed lately, but there are still many warnings to be fixed.
Board maintainers, please check your own boards.
YES, SIR !
Or, somebody who volunteers to fix them? Thanks!
mxs should be fixed and dwc2 usb was fixed by you , thanks :)
w+../arch/arm/cpu/arm926ejs/mxs/spl_boot.c:44:26: warning: 'iomux_boot' defined but not used [-Wunused-const-variable=] w+../common/cli_readline.c:20:21: warning: 'tab_seq' defined but not used [-Wunused-const-variable=] w+../common/cli_readline.c:19:19: warning: 'erase_seq' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/dwc2_udc_otg.c:72:19: warning: 'driver_desc' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap4/hw_data.c:136:3: warning: 'abe_dpll_params_sysclk_196608khz' defined but not used [-Wunused-const-variable=] w+../drivers/clk/rockchip/clk_rk3288.c:135:29: warning: 'cpll_init_cfg' defined but not used [-Wunused-const-variable=] w+../drivers/clk/rockchip/clk_rk3288.c:134:29: warning: 'gpll_init_cfg' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:226:33: warning: 'dual_0S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:213:33: warning: 'dual_S0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:196:33: warning: 'dual_0D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:179:33: warning: 'dual_D0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:162:33: warning: 'dual_SS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:140:33: warning: 'dual_SD' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:119:33: warning: 'dual_DS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:92:33: warning: 'dual_DD' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/ether.c:501:17: warning: 'mdlm_detail_desc' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:80:33: warning: 'single_S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:63:33: warning: 'single_D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:36:33: warning: 'single_Q' defined but not used [-Wunused-const-variable=] w+../board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c:228:29: warning: 'usdhc1_pads' defined but not used [-Wunused-const-variable=] w+../drivers/net/eepro100.c:210:19: warning: 'i82557_config_cmd' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:456:33: warning: 'dual_0S' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:443:33: warning: 'dual_S0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:426:33: warning: 'dual_0D' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:409:33: warning: 'dual_D0' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:392:33: warning: 'dual_SS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:370:33: warning: 'dual_SD' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:349:33: warning: 'dual_DS' defined but not used [-Wunused-const-variable=] w+../drivers/ddr/fsl/options.c:322:33: warning: 'dual_DD' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:204:33: warning: 'abe_dpll_params_32k_196608khz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:131:4: warning: 'core_dpll_params_2128mhz_ddr266_es2' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:120:4: warning: 'core_dpll_params_2128mhz_ddr266' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:65:33: warning: 'mpu_dpll_params_499mhz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:54:33: warning: 'mpu_dpll_params_400mhz' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:32:33: warning: 'mpu_dpll_params_1_5ghz' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:136:29: warning: 'gpios_pads' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:171:29: warning: 'usdhc4_pads' defined but not used [-Wunused-const-variable=] w+../board/phytec/pcm058/pcm058.c:112:29: warning: 'nfc_pads' defined but not used [-Wunused-const-variable=] w+../board/bachmann/ot1200/ot1200.c:276:29: warning: 'pwm_pad' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-omap2/omap5/hw_data.c:193:3: warning: 'abe_dpll_params_sysclk_196608khz' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:69:28: warning: 'SEQ_SLPIN' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:49:28: warning: 'SEQ_APON' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:25:28: warning: 'SEQ_TEMP_SWIRE' defined but not used [-Wunused-const-variable=] w+../drivers/video/ld9040.c:13:28: warning: 'SEQ_SWRESET' defined but not used [-Wunused-const-variable=] w+../board/toradex/colibri_imx7/colibri_imx7.c:101:29: warning: 'usdhc3_emmc_pads' defined but not used [-Wunused-const-variable=] w+../arch/arm/mach-rockchip/rk3036-board-spl.c:19:34: warning: 'grf' defined but not used [-Wunused-const-variable=] w+../board/congatec/cgtqmx6eval/cgtqmx6eval.c:84:29: warning: 'usdhc3_pads' defined but not used [-Wunused-const-variable=] w+../board/congatec/cgtqmx6eval/cgtqmx6eval.c:74:29: warning: 'usdhc2_pads' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/at91_udc.c:1506:35: warning: 'at91sam9263_udc_caps' defined but not used [-Wunused-const-variable=] w+../drivers/usb/gadget/at91_udc.c:1389:35: warning: 'at91rm9200_udc_caps' defined but not used [-Wunused-const-variable=] w+../board/gateworks/gw_ventana/common.c:140:29: warning: 'gwproto_gpio_pads' defined but not used [-Wunused-const-variable=]
participants (3)
-
Marek Vasut -
Masahiro Yamada -
Tom Rini