[U-Boot] [PATCH] arm: a320: enable tagged list support
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com --- include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index 0527822..f12977b 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/*----------------------------------------------------------------------- + * Linux kernel tagged list + */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS + +/*----------------------------------------------------------------------- * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Dear Po-Yu Chuang,
In message 1305531660-1595-1-git-send-email-ratbert.chuang@gmail.com you wrote:
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index 0527822..f12977b 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/*-----------------------------------------------------------------------
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/*-----------------------------------------------------------------------
Please also fix the incorrect multiline comment style while modifying this code. Thanks.
Best regards,
Wolfgang Denk
Dear Wolfgang,
On Mon, May 16, 2011 at 7:42 PM, Wolfgang Denk wd@denx.de wrote:
Dear Po-Yu Chuang,
In message 1305531660-1595-1-git-send-email-ratbert.chuang@gmail.com you wrote:
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index 0527822..f12977b 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/*-----------------------------------------------------------------------
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/*-----------------------------------------------------------------------
Please also fix the incorrect multiline comment style while modifying this code. Thanks.
OK, I will resubmit this patch with a preceding clean patch.
Best regards, Po-Yu Chuang
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com --- include/configs/a320evb.h | 32 ++++++++++++++------------------ 1 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index 0527822..f832d52 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -24,29 +24,29 @@
#include <asm/arch/a320.h>
-/*----------------------------------------------------------------------- +/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
#undef CONFIG_SKIP_LOWLEVEL_INIT
-/*----------------------------------------------------------------------- +/* * Power Management Unit */ #define CONFIG_FTPMU010_POWER
-/*----------------------------------------------------------------------- +/* * Timer */ #define CONFIG_SYS_HZ 1000 /* timer ticks per second */
-/*----------------------------------------------------------------------- +/* * Real Time Clock */ #define CONFIG_RTC_FTRTC010
-/*----------------------------------------------------------------------- +/* * Serial console configuration */
@@ -62,7 +62,7 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
-/*----------------------------------------------------------------------- +/* * Ethernet */ #define CONFIG_NET_MULTI @@ -70,7 +70,7 @@
#define CONFIG_BOOTDELAY 3
-/*----------------------------------------------------------------------- +/* * Command line configuration. */ #include <config_cmd_default.h> @@ -79,7 +79,7 @@ #define CONFIG_CMD_DATE #define CONFIG_CMD_PING
-/*----------------------------------------------------------------------- +/* * Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ @@ -96,7 +96,7 @@ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-/*----------------------------------------------------------------------- +/* * Stack sizes * * The stack sizes are set up in start.S using the settings below @@ -107,16 +107,12 @@ #define CONFIG_STACKSIZE_FIQ (4 * 1024) /* FIQ stack */ #endif
-/*----------------------------------------------------------------------- +/* * Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
-/*----------------------------------------------------------------------- - * size in bytes reserved for initial data -*/ - -/*----------------------------------------------------------------------- +/* * SDRAM controller configuration */ #define CONFIG_SYS_FTSDMC020_TP0 (FTSDMC020_TP0_TRAS(2) | \ @@ -136,7 +132,7 @@ FTSDMC020_BANK_MBW_32 | \ FTSDMC020_BANK_SIZE_64M)
-/*----------------------------------------------------------------------- +/* * Physical Memory Map */ #define CONFIG_NR_DRAM_BANKS 1 /* we have 1 bank of DRAM */ @@ -159,7 +155,7 @@
#define CONFIG_SYS_TEXT_BASE 0
-/*----------------------------------------------------------------------- +/* * Static memory controller configuration */
@@ -198,7 +194,7 @@ { FTSMC020_BANK1_CONFIG, FTSMC020_BANK1_TIMING, }, \ }
-/*----------------------------------------------------------------------- +/* * FLASH and environment organization */
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com --- v2: (new) fix multiline comment style
v3: rebase
include/configs/a320evb.h | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index dfab0f4..f832d52 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -24,29 +24,29 @@
#include <asm/arch/a320.h>
-/*----------------------------------------------------------------------- +/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
#undef CONFIG_SKIP_LOWLEVEL_INIT
-/*----------------------------------------------------------------------- +/* * Power Management Unit */ #define CONFIG_FTPMU010_POWER
-/*----------------------------------------------------------------------- +/* * Timer */ #define CONFIG_SYS_HZ 1000 /* timer ticks per second */
-/*----------------------------------------------------------------------- +/* * Real Time Clock */ #define CONFIG_RTC_FTRTC010
-/*----------------------------------------------------------------------- +/* * Serial console configuration */
@@ -62,7 +62,7 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
-/*----------------------------------------------------------------------- +/* * Ethernet */ #define CONFIG_NET_MULTI @@ -70,7 +70,7 @@
#define CONFIG_BOOTDELAY 3
-/*----------------------------------------------------------------------- +/* * Command line configuration. */ #include <config_cmd_default.h> @@ -79,7 +79,7 @@ #define CONFIG_CMD_DATE #define CONFIG_CMD_PING
-/*----------------------------------------------------------------------- +/* * Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ @@ -96,7 +96,7 @@ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-/*----------------------------------------------------------------------- +/* * Stack sizes * * The stack sizes are set up in start.S using the settings below @@ -107,12 +107,12 @@ #define CONFIG_STACKSIZE_FIQ (4 * 1024) /* FIQ stack */ #endif
-/*----------------------------------------------------------------------- +/* * Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
-/*----------------------------------------------------------------------- +/* * SDRAM controller configuration */ #define CONFIG_SYS_FTSDMC020_TP0 (FTSDMC020_TP0_TRAS(2) | \ @@ -132,7 +132,7 @@ FTSDMC020_BANK_MBW_32 | \ FTSDMC020_BANK_SIZE_64M)
-/*----------------------------------------------------------------------- +/* * Physical Memory Map */ #define CONFIG_NR_DRAM_BANKS 1 /* we have 1 bank of DRAM */ @@ -155,7 +155,7 @@
#define CONFIG_SYS_TEXT_BASE 0
-/*----------------------------------------------------------------------- +/* * Static memory controller configuration */
@@ -194,7 +194,7 @@ { FTSMC020_BANK1_CONFIG, FTSMC020_BANK1_TIMING, }, \ }
-/*----------------------------------------------------------------------- +/* * FLASH and environment organization */
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com --- include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/* + * Linux kernel tagged list + */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS + +/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Dear Albert,
On Tue, May 17, 2011 at 11:11 AM, Po-Yu Chuang ratbert.chuang@gmail.com wrote:
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */ -- 1.6.3.3
Is it possible to accept this patch series in v2011.06?
[U-Boot,v2,1/2] arm: a320: fix multiline comment style http://patchwork.ozlabs.org/patch/95847/
[U-Boot,v2,2/2] arm: a320: enable tagged list support http://patchwork.ozlabs.org/patch/95848/
Best regards, Po-Yu Chuang
Dear Albert,
On Thu, Jun 9, 2011 at 2:35 PM, Po-Yu Chuang ratbert.chuang@gmail.com wrote:
Dear Albert,
On Tue, May 17, 2011 at 11:11 AM, Po-Yu Chuang ratbert.chuang@gmail.com wrote:
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */ -- 1.6.3.3
Is it possible to accept this patch series in v2011.06?
[U-Boot,v2,1/2] arm: a320: fix multiline comment style http://patchwork.ozlabs.org/patch/95847/
[U-Boot,v2,2/2] arm: a320: enable tagged list support http://patchwork.ozlabs.org/patch/95848/
Just now I noticed that your mail address has changed. So resend this mail.
Best regards, Po-Yu Chuang
Hi Po-Yu Chuang,
Le 09/06/2011 08:44, Po-Yu Chuang a écrit :
Dear Albert,
On Thu, Jun 9, 2011 at 2:35 PM, Po-Yu Chuangratbert.chuang@gmail.com wrote:
Dear Albert,
On Tue, May 17, 2011 at 11:11 AM, Po-Yu Chuangratbert.chuang@gmail.com wrote:
From: Po-Yu Chuangratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuangratbert@faraday-tech.com
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include<asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/*
- CPU and Board Configuration Options
*/
#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
1.6.3.3
Is it possible to accept this patch series in v2011.06?
[U-Boot,v2,1/2] arm: a320: fix multiline comment style http://patchwork.ozlabs.org/patch/95847/
[U-Boot,v2,2/2] arm: a320: enable tagged list support http://patchwork.ozlabs.org/patch/95848/
Just now I noticed that your mail address has changed. So resend this mail.
Sorry for the delay. Can you please rebase and repost as V3? Ill pull them in ASAP.
Best regards, Po-Yu Chuang
Amicalement,
From: Po-Yu Chuang ratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com --- v2: add a preceding patch to fix multiline comment style
v3: rebase
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include <asm/arch/a320.h>
/* + * Linux kernel tagged list + */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS + +/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Hi Po Yu Chuang,
On 19/07/2011 04:56, Po-Yu Chuang wrote:
From: Po-Yu Chuangratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuangratbert@faraday-tech.com
v2: add a preceding patch to fix multiline comment style
v3: rebase
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include<asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/*
- CPU and Board Configuration Options
*/ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!
Amicalement,
Dear Albert,
On Thu, Aug 4, 2011 at 5:32 PM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Po Yu Chuang,
On 19/07/2011 04:56, Po-Yu Chuang wrote:
From: Po-Yu Chuangratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuangratbert@faraday-tech.com
v2: add a preceding patch to fix multiline comment style
v3: rebase
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include<asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/* * CPU and Board Configuration Options */ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!
Just to remind you.
There is a preceding patch "arm: a320: fix multiline comment style" according to Wolfgang's request.
http://patchwork.ozlabs.org/patch/105374/
I guess that's why you need local fix.
Best regards, Po-Yu Chuang
Hi Po Yu Chuang,
On 04/08/2011 11:44, Po-Yu Chuang wrote:
Dear Albert,
On Thu, Aug 4, 2011 at 5:32 PM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Po Yu Chuang,
On 19/07/2011 04:56, Po-Yu Chuang wrote:
From: Po-Yu Chuangratbert@faraday-tech.com
Signed-off-by: Po-Yu Chuangratbert@faraday-tech.com
v2: add a preceding patch to fix multiline comment style
v3: rebase
include/configs/a320evb.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/configs/a320evb.h b/include/configs/a320evb.h index f832d52..62913b5 100644 --- a/include/configs/a320evb.h +++ b/include/configs/a320evb.h @@ -25,6 +25,12 @@ #include<asm/arch/a320.h>
/*
- Linux kernel tagged list
- */
+#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS
+/*
- CPU and Board Configuration Options
*/ #undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
Applied to u-boot-arm (after local fix to context lines -- my fault entirely, waited too long before applying it), thanks!
Just to remind you.
There is a preceding patch "arm: a320: fix multiline comment style" according to Wolfgang's request.
http://patchwork.ozlabs.org/patch/105374/
I guess that's why you need local fix.
Thanks -- I'll reorder u-boot-arm to apply the style fix first.
Best regards, Po-Yu Chuang
Amicalement,
participants (3)
-
Albert ARIBAUD -
Po-Yu Chuang -
Wolfgang Denk