[U-Boot-Users] [PATCH] Command history and Command buffer editing

I made this patch using 'diff' on two source trees; I got the original copies of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the patch.
All code changes are local to common/main.c
Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).
Please let me know if there is something I need to do to make the patch acceptable.
* Patch by James MacAulay Sept 27, 2005 - Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README. - Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.

d'oh!
I discovered a foolish mistake in my patch release methods. I missed a last minute update to the included headers section. here is the new patch...
* Patch by James MacAulay Sept 27, 2005 - Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README. - Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.
On 9/27/05, J Mac macamirix.com@gmail.com wrote:
I made this patch using 'diff' on two source trees; I got the original copies of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the patch.
All code changes are local to common/main.c
Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).
Please let me know if there is something I need to do to make the patch acceptable.
- Patch by James MacAulay Sept 27, 2005 - Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README. - Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.

James - I applied this patch when you first sent it out to my local development sources and had no problems. I really like the added functionality.
I would definitely vote for adding it.
A suggestion: How about modifying things so that only unique commands get added to the history? In other words, if I type 'printenv' two consecutive times, only add the command once to the history buffer.
Keith
I made this patch using 'diff' on two source trees; I got the original
copies
of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the
patch.
All code changes are local to common/main.c
Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).
Please let me know if there is something I need to do to make the patch acceptable.
- Patch by James MacAulay Sept 27, 2005
- Add a configuration option CONFIG_COMMAND_HISTORY to implement
command
history. Uses up and down arrow keys to scroll through history.
Other
options are described in README.
- Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move
through
command buffer. Other options are described in README.
participants (2)
-
J Mac
-
Keith J Outwater