Re: [U-Boot] [PATCH v3 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 02.02.2017 um 20:33 schrieb Karsten Merker:
On Thu, Feb 02, 2017 at 08:10:54PM +0100, Heiner Kallweit wrote:
Am 31.01.2017 um 14:24 schrieb Jaehoon Chung:
On 01/28/2017 05:55 AM, Heiner Kallweit wrote:
This driver implements MMC support on Meson GX (S905) based systems. It's based on Carlo Caione's work, changes:
- BLK support added
- general refactoring
Signed-off-by: Carlo Caione carlo@caione.org Signed-off-by: Andreas Färber afaerber@suse.de Signed-off-by: Heiner Kallweit hkallweit1@gmail.com
Andreas's comment is what this patch's author is Carlo..Not just add Signed-off tag for Carlo.
When you send the email, needs to add "From: Carlo Caione carlo@caione.org", not yours.
I sent a v4 series addressing the review comments. I tried sending patch 2 with Carlo as "From:", however the mail provider replaced this with my default mail address. I checked with my other mail providers, they also allow only sender addresses belonging to me.
IIRC putting "From: Carlo Caione carlo@caione.org" as the first line in the commit log makes git set the patch author accordingly during "git am" (regardless of what is in the "From:" header of the email).
Thanks for the hint. Indeed that's what the git am docu says: "From: " and "Subject: " lines starting the body override the respective commit author name and title values taken from the headers. Patchwork doesn't seem to be that smart ..
HTH, Karsten

Am 02.02.2017 um 20:41 schrieb Heiner Kallweit:
Am 02.02.2017 um 20:33 schrieb Karsten Merker:
On Thu, Feb 02, 2017 at 08:10:54PM +0100, Heiner Kallweit wrote:
Am 31.01.2017 um 14:24 schrieb Jaehoon Chung:
On 01/28/2017 05:55 AM, Heiner Kallweit wrote:
This driver implements MMC support on Meson GX (S905) based systems. It's based on Carlo Caione's work, changes:
- BLK support added
- general refactoring
Signed-off-by: Carlo Caione carlo@caione.org Signed-off-by: Andreas Färber afaerber@suse.de Signed-off-by: Heiner Kallweit hkallweit1@gmail.com
Andreas's comment is what this patch's author is Carlo..Not just add Signed-off tag for Carlo.
When you send the email, needs to add "From: Carlo Caione carlo@caione.org", not yours.
I sent a v4 series addressing the review comments. I tried sending patch 2 with Carlo as "From:", however the mail provider replaced this with my default mail address. I checked with my other mail providers, they also allow only sender addresses belonging to me.
IIRC putting "From: Carlo Caione carlo@caione.org" as the first line in the commit log makes git set the patch author accordingly during "git am" (regardless of what is in the "From:" header of the email).
Thanks for the hint. Indeed that's what the git am docu says: "From: " and "Subject: " lines starting the body override the respective commit author name and title values taken from the headers. Patchwork doesn't seem to be that smart ..
I believe I already pointed you to the --author command line option?
git commit --amend --author="Carlo ... <...>"
Regards, Andreas
participants (2)
-
Andreas Färber
-
Heiner Kallweit