[U-Boot-Users] [PATCH] adsvix: Fix undefined reference to inb and outb build errors
- undefined reference to `inb' - undefined reference to `outb'
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com --- include/configs/adsvix.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/configs/adsvix.h b/include/configs/adsvix.h index 703d312..58914cb 100644 --- a/include/configs/adsvix.h +++ b/include/configs/adsvix.h @@ -310,6 +310,7 @@
#define CONFIG_PXA_PCMCIA 1 #define CONFIG_PXA_IDE 1 +#define __io
#define CONFIG_PCMCIA_SLOT_A 1 /* just to keep build system happy */
On 02:31 Fri 02 May , Marcel Ziswiler wrote:
- undefined reference to `inb'
- undefined reference to `outb'
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com
include/configs/adsvix.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/configs/adsvix.h b/include/configs/adsvix.h index 703d312..58914cb 100644 --- a/include/configs/adsvix.h +++ b/include/configs/adsvix.h @@ -310,6 +310,7 @@
#define CONFIG_PXA_PCMCIA 1 #define CONFIG_PXA_IDE 1 +#define __io
This is not the good way to do it
__io is suppose to declare as this #define __io(a) ((volatile void *)(a))
NACK
This will be fix by ad the asm-arm/arch-*/io.h
and cleany the asm/io.h
Best Regards, J.
Jean-Christophe PLAGNIOL-VILLARD <plagnioj <at> jcrosoft.com> writes:
This is not the good way to do it
I just noticed it to be done like that for the two SH boards r2dplus and r7780mp and figured it to be good enough for use on ARM as well.
__io is suppose to declare as this #define __io(a) ((volatile void *)(a))
I am very well aware of that's the way the kernel guys use it.
This will be fix by ad the asm-arm/arch-*/io.h
and cleany the asm/io.h
OK, go ahead. It would be nice if that made it into 1.3.3 as the adsvix board currently does not build at all.
Cheers
Marcel Ziswiler
participants (2)
-
Jean-Christophe PLAGNIOL-VILLARD -
Marcel Ziswiler