Re: [U-Boot-Users] [PATCH] Setting processor endianess for USB modules
Dear Markus,
Dear Christian,
"Christian Eggers" ceggers@gmx.de writes:
I've recognized that a lot of USB code in U-Boot uses the macros swap_16() and swap_32() which are defined in usb.h. The behaviour of the macros is controlled by the define LITTLEENDIAN.
Is there a good reason NOT to use the macros provided in asm/byteorder.h (as in the appropriate code in Linux-2.4 )?
Largely not. But be carefull. Besides big and little endian CPUs we also have controllers that operate in big or little endian (see CFG_OHCI_BE_CONTROLLER), and then there are PCI controllers whose registers need to be accessed as little endian (CFG_OHCI_SWAP_REG_ACCESS).
I didn't change much in usb_ohci.c. But I think there has been a small error with byteorder conversion (see patch).
But your right, there is no real for LITTLEENDIAN.
I think that switching to these functions might be useful in order to eliminate the need to use the LITTLEENDIAN define for specifying the byteorder. It seems that LITTLEENDIAN is not used outside the USB code.
Right. Patches cleaning this up are more than welcome! Please note that cleaning up USB drivers under the cpu/ directory is a waste of time though. Boards using these drivers should be converted to use the generic infrastructure in drivers/usb/ instead.
The main focus of my patch is on common/usb.c, common/usb_kbd.c and common/usb_storage.c. Unfortunately I couldn't test my changes in usb_kbd.c because I don't have such a device.
Removing the LITTLEENDIAN define seems not to be as easy as I thought first. A bunch of other modules use the swap_16() and swap_32() defines from usb.h so I wasn't able to remove these for now.
regards Christian Eggers
Signed-off-by: Christian Eggers christian.eggers@kathrein.de
Dear Christian,
Thank you for your contribution. Unfortunately I have problems applying your patch against a top of git tree:
[mk@pollux u-boot-mainline]$ patch -p5 --dry-run < ~/2008-05-05-usb-remove-LITTLE_ENDIAN-define missing header for unified diff at line 4 of patch patching file common/usb.c missing header for unified diff at line 130 of patch patching file common/usb_kbd.c missing header for unified diff at line 177 of patch patching file common/usb_storage.c Hunk #2 succeeded at 475 (offset 3 lines). Hunk #4 succeeded at 1223 (offset 3 lines). missing header for unified diff at line 241 of patch patching file drivers/usb/usb_ohci.c Reversed (or previously applied) patch detected! Assume -R? [n]
I would suggest you use git for generating and sending patches.
Also please make sure to read the guidelines for submitting patches in the README. Especially:
- provide a changelog entry for the logs - send patches inline - if you don't use git for generating patches, at least run diff from the parent directory of U-Boot - don't send html mails, the makes it impossible to use git-am
Registergericht / Register court: Amtsgericht Traunstein, HRA 460 / local court Traunstein, certificate of registration no. 460 Geschäftsführender persönlich haftender Gesellschafter / Personally liable managing partner: Prof. Dr. Dr. h.c. Anton Kathrein, Dipl.-Betriebswirt (MBA-equivalent) Erfüllungsort und Gerichtsstand / Place of performance and place of jurisdiction: Rosenheim This e-mail is confidential and may contain privileged information. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The sender therefore does not accept liability for any errors or omissions in the contents of this message which arise as a result of e-mail transmission. We believe but do not warrant that this e-mail and any attachments are virus free. You must therefore take full responsibility for virus checking.
And if you can, please avoid sending this to public mailings lists.
Please cleanup and resubmit.
Thanks!
Best regards
Markus Klotzbuecher
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
participants (2)
-
Christian Eggers -
Markus Klotzbücher