Re: [U-Boot] Clean-up of s3c24x0 header files

Wolfgang Denk

2 Dec 2009 2 Dec '09

11:09 p.m.

Hi Kevin,

looking at the code resulting from commit 9ebfdc20 again, I see that you keep a LOT of uppercase variable names, which are not allowed as per coding style. DO you intend to convert these to proper lower-case names any time soon?

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de A father doesn't destroy his children. -- Lt. Carolyn Palamas, "Who Mourns for Adonais?", stardate 3468.1.

Show replies by date

kevin.morfitt＠fearnside-systems.co.uk

4 Dec 4 Dec

11:42 p.m.

New subject: [U-Boot] Clean-up of s3c24x0 header files

Hi Wolfgang

On 02/12/2009 22:09, Wolfgang Denk wrote:

...

Hi Kevin,

looking at the code resulting from commit 9ebfdc20 again, I see that you keep a LOT of uppercase variable names, which are not allowed as per coding style. DO you intend to convert these to proper lower-case names any time soon?

I can't see any variables with upper case names in the generic s3c24x0 code. The other arm920t code probably still has some but the s3c24x0 headers I patched only uses upper case names for constants and members of structs that map onto the CPU registers. For example:

#define S3C24X0_MEMCTL_BASE 0x14000000

struct s3c24x0_memctl { - S3C24X0_REG32 BWSCON; - S3C24X0_REG32 BANKCON[8]; - S3C24X0_REG32 REFRESH; - S3C24X0_REG32 BANKSIZE; - S3C24X0_REG32 MRSRB6; - S3C24X0_REG32 MRSRB7; + u32 BWSCON; + u32 BANKCON[8]; + u32 REFRESH; + u32 BANKSIZE; + u32 MRSRB6; + u32 MRSRB7; };

Best Regards Kevin

...

Best regards,

Wolfgang Denk

-- Kevin Morfitt Fearnside Systems Ltd 25 Holbeck Road Nottingham NG8 3PB t: 0115 9136703 m: 07939 126277 e: kevin.morfitt@fearnside-systems.co.uk __________ Information from ESET NOD32 Antivirus, version of virus signature database 4661 (20091204) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com

Wolfgang Denk

5 Dec 5 Dec

2:05 a.m.

New subject: [U-Boot] Clean-up of s3c24x0 header files

Dear Kevin,

In message 4B19905D.8040801@fearnside-systems.co.uk you wrote:

...

On 02/12/2009 22:09, Wolfgang Denk wrote:

...
Hi Kevin,

looking at the code resulting from commit 9ebfdc20 again, I see that you keep a LOT of uppercase variable names, which are not allowed as per coding style. DO you intend to convert these to proper lower-case names any time soon?

I can't see any variables with upper case names in the generic s3c24x0 code. The other arm920t code probably still has some but the s3c24x0 headers I patched only uses upper case names for constants and members of structs that map onto the CPU registers. For example:

Members of struct are just variables as well. They must use lower case names.

...

u32 BWSCON;

u32 BANKCON[8];

u32 REFRESH;

u32 BANKSIZE;

u32 MRSRB6;

u32 MRSRB7;

Right, all these need to be fixed.

Best regards,

Wolfgang Denk

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de ADVISORY: There is an Extremely Small but Nonzero Chance That, Through a Process Know as "Tunneling," This Product May Spontaneously Disappear from Its Present Location and Reappear at Any Random Place in the Universe, Including Your Neighbor's Domicile. The Manufacturer Will Not Be Responsible for Any Damages or Inconvenience That May Result.

5633

Age (days ago)

5636

Last active (days ago)

List overview

Download

2 comments

2 participants

tags (0)

participants (2)

kevin.morfitt＠fearnside-systems.co.uk
Wolfgang Denk