[U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization
Hi,
Sorry. Re-sending as uboot-mailing list was not properly Included last time
Regards Gururaja
- According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), --Timer Value Register @ TIMER Base + 4 is Read-only. So removed code which writes to this register --Prescale Value (Bits 3-2 of TIMER Control register) can only be one of 00,01,10. 11 is undefined. So bringing Correcting the same to point to 00.
Signed-off-by: Gururaja Hebbar <gururajakr@sanyo.co.in blocked::mailto:gururajakr@sanyo.co.in > --- cpu/arm926ejs/versatile/timer.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/cpu/arm926ejs/versatile/timer.c b/cpu/arm926ejs/versatile/timer.c index 32872d2..9659b67 100644 --- a/cpu/arm926ejs/versatile/timer.c +++ b/cpu/arm926ejs/versatile/timer.c @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD; /* TimerLoad */ - *(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD; /* TimerValue */ - *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x8C; + *(volatile ulong *)(CFG_TIMERBASE + 8) = 0x80;
/* init the timestamp and lastdec value */ reset_timer_masked();
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C189@blrms.slti.sanyo.co.in you wrote:
Sorry. Re-sending as uboot-mailing list was not properly Included last time
Regards Gururaja
Please do not include such comments in the commit message part of the patch. They belong *below* the '---" line.
@@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */
^^^^^^^^^^^^^
- *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /*
TimerValue */
^^^^^^^^^^^^^
Your patch is line-wrapped and cannot be applied.
------_=_NextPart_001_01C8ED71.42919551 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
And *NEVER* post HTML here!
Best regards,
Wolfgang Denk
Hi,
@@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */
^^^^^^^^^^^^^
- *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /*
TimerValue */
^^^^^^^^^^^^^
Your patch is line-wrapped and cannot be applied.
I Checked the Original Source File & found this.
*(volatile ulong *)(CFG_TIMERBASE + 0) = CFG_TIMER_RELOAD; /* TimerLoad */ ---> This line ends @ Column 80 *(volatile ulong *)(CFG_TIMERBASE + 4) = CFG_TIMER_RELOAD; /* TimerValue */ ---> This line ends @ Column 81
I just removed the Second Line since it was Invalid.
I am really sorry for troubling but i have little issue finding the mistake. Now in order to remove this, kindly let me know what i have to do.
And *NEVER* post HTML here!
Will not repeat.
Regards Gururaja
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C1B7@blrms.slti.sanyo.co.in you wrote:
Hi,
@@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */
^^^^^^^^^^^^^
- *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD; /*=20
TimerValue */
^^^^^^^^^^^^^
Your patch is line-wrapped and cannot be applied.
I Checked the Original Source File & found this.
*(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */ ---> This line ends @ Column 80 *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /* TimerValue */ ---> This line ends @ Column 81
I just removed the Second Line since it was Invalid.
I am really sorry for troubling but i have little issue finding the mistake. Now in order to remove this, kindly let me know what i have to do.
Please resubmit your patch, without line wrapping.
Best regards,
Wolfgang Denk
Hi,
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C1B7@blrms.slti.sanyo.co.in you wrote:
Hi,
@@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */
^^^^^^^^^^^^^
- *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD;
/*=20 TimerValue */
^^^^^^^^^^^^^
Your patch is line-wrapped and cannot be applied.
I Checked the Original Source File & found this.
*(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */ ---> This line ends @ Column 80 *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /* TimerValue */ ---> This line ends @ Column 81
I just removed the Second Line since it was Invalid.
I am really sorry for troubling but i have little issue finding the mistake. Now in order to remove this, kindly let me know what i have to do.
Please resubmit your patch, without line wrapping.
Yes, I think i couldn't make myself clear. The ORIGINAL Source Code/Line i need to REMOVE itself is greater than 80 Column. I am not adding any code. I am just removing 1 line that is not required.
Kindly Have a look @ File u-boot-1.3.3/cpu/arm926ejs/versatile/timer.c @ line 53. I need to remove this Line. So i request to let me know how to remove a line that's already is broken.
TIA
Regards Gururaja
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C1EF@blrms.slti.sanyo.co.in you wrote:
*(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */
^^^^^^^^^^^^^
- *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD;
/*=20 TimerValue */
^^^^^^^^^^^^^
Your patch is line-wrapped and cannot be applied.
I Checked the Original Source File & found this.
The original source file has nothing to do with this problem.
Please resubmit your patch, without line wrapping.
Yes, I think i couldn't make myself clear. The ORIGINAL Source Code/Line i need to REMOVE itself is greater than 80 Column. I am not adding any code. I am just removing 1 line that is not required.
Yes, but that is NOT the problem. The problem is that your mailer is wrapping long lines when it sends your patch, thus corrpting it.
I need to remove this Line. So i request to let me know how to remove a line that's already is broken.
The source line may be long, but it is not broken.
It is your mailer which corrupts the patch by wrapping the long lines into two lines.
Best regards,
Wolfgang Denk
Hi,
The original source file has nothing to do with this problem. Yes, but that is NOT the problem. The problem is that your mailer is
wrapping long lines when it sends your patch, thus corrpting it.
The source line may be long, but it is not broken. It is your mailer which corrupts the patch by wrapping the long lines
into two lines.
Yes. Sorry for the mistake. It was my M$ Office which was wrapping the mail @ column 76 & hence the issue. I have changed it to 81 & i have Re-Submitted the Patch. Hopefully. Its Corrected Now.
TIA
Regards Gururaja
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C204@blrms.slti.sanyo.co.in you wrote:
Yes. Sorry for the mistake. It was my M$ Office which was wrapping the mail @ column 76 & hence the issue. I have changed it to 81 & i have Re-Submitted the Patch. Hopefully. Its Corrected Now.
Changed it to 81? I don't understand. What happens when your next patch has a line with 85 characters? I do not want to see any line-wrapped patches again.
Please turn this evil line wrapping off completely.
Best regards,
Wolfgang Denk
Hi,
In message <5BF78BCE8D9BF14A83F836BD9E3916BA23C204@blrms.slti.sanyo.co.in
you wrote:
Yes. Sorry for the mistake. It was my M$ Office which was
wrapping the
mail @ column 76 & hence the issue. I have changed it to 81 & i have Re-Submitted the Patch. Hopefully. Its Corrected Now.
Changed it to 81? I don't understand. What happens when your next patch has a line with 85 characters? I do not want to see any line-wrapped patches again.
Please turn this evil line wrapping off completely.
I can turn this off completely in M$ Office For Plain Text Mails, It Automatically Wraps the text. We can only set the Number of characters to wrap I checked & found that the max characters that can be allowed b4 wrapping is 132
Regards Gururaja
In message 5BF78BCE8D9BF14A83F836BD9E3916BA23C205@blrms.slti.sanyo.co.in you wrote:
I can turn this off completely in M$ Office For Plain Text Mails, It Automatically Wraps the text. We can only set the Number of characters to wrap I checked & found that the max characters that can be allowed b4 wrapping is 132
...which is why we always recommend to use git-send-email to send patches. Do not use any crappy M$ stuff.
Best regards,
Wolfgang Denk
participants (2)
-
Gururaja Hebbar K R -
Wolfgang Denk