Re: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard
+U-boot list
---------- Forwarded message ---------- From: Joel A Fernandes agnel.joel@gmail.com Date: Fri, Aug 26, 2011 at 11:45 PM Subject: Re: [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard To: Jason Kridner jkridner@beagleboard.org
The logic is wrong here. I don't remember the polarity, but I do remember that it is xM-A and xM-B that are the oddballs. I believe this is the correct change:
Hi Jason,
LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
- switch (get_board_revision()) {
- case REVISION_XM_A:
- case REVISION_XM_B:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
- break;
- default:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
and, this should be TWL4030_LED_LEDEN_LEDBON
Am I correct?
Thanks Joel
Hi Joel,
Le 27/08/2011 06:46, Joel A Fernandes a écrit :
The logic is wrong here. I don't remember the polarity, but I do remember that it is xM-A and xM-B that are the oddballs. I believe this is the correct change:
Hi Jason,
LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
switch (get_board_revision()) {case REVISION_XM_A:case REVISION_XM_B:twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
break;default:twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);and, this should be TWL4030_LED_LEDEN_LEDBON
Am I correct?
LEDA & LEDB are active low Open Drain outputs so enabling LEDAON bit in LEDEN means LEDA output is at low level.
Eric
On Sat, Aug 27, 2011 at 9:51 AM, Eric Bénard eric@eukrea.com wrote:
Hi Joel,
Le 27/08/2011 06:46, Joel A Fernandes a écrit :
The logic is wrong here. I don't remember the polarity, but I do remember that it is xM-A and xM-B that are the oddballs. I believe this is the correct change:
Hi Jason,
LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
- switch (get_board_revision()) {
- case REVISION_XM_A:
- case REVISION_XM_B:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
- break;
- default:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
and, this should be TWL4030_LED_LEDEN_LEDBON
Am I correct?
LEDA & LEDB are active low Open Drain outputs so enabling LEDAON bit in LEDEN means LEDA output is at low level.
Thanks for resolving that mystery. I just figured out what I thought it should be by looking at the previous default, which should be the new default as well with only XM_A and XM_B are different.
Eric _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
All,
I'm post a v2 now, please give ACKs, thanks :)
On Sat, Aug 27, 2011 at 11:19 AM, Jason Kridner jkridner@beagleboard.org wrote:
On Sat, Aug 27, 2011 at 9:51 AM, Eric Bénard eric@eukrea.com wrote:
Hi Joel,
Le 27/08/2011 06:46, Joel A Fernandes a écrit :
The logic is wrong here. I don't remember the polarity, but I do remember that it is xM-A and xM-B that are the oddballs. I believe this is the correct change:
Hi Jason,
LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
- switch (get_board_revision()) {
- case REVISION_XM_A:
- case REVISION_XM_B:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
- break;
- default:
- twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
and, this should be TWL4030_LED_LEDEN_LEDBON
Am I correct?
LEDA & LEDB are active low Open Drain outputs so enabling LEDAON bit in LEDEN means LEDA output is at low level.
Thanks for resolving that mystery. I just figured out what I thought it should be by looking at the previous default, which should be the new default as well with only XM_A and XM_B are different.
Eric _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
participants (3)
-
Eric Bénard -
Jason Kridner -
Joel A Fernandes