Re: [U-Boot-Users] [PATCH 04/13] microblaze: add Emaclite ethernet driver
In message de470d32d7222874eac8134583889844c80e4bcb.1206711077.git.monstr@monstr.eu you wrote:
From: Michal Simek monstr@monstr.eu
Signed-off-by: Michal Simek monstr@monstr.eu
I see you sneaked this in via your microblaze custodian repo. This was a Bad Thing, and I ask you not to do such things. You were supposed to run this through the Net custodian.
Ditto for [PATCH 05/13] microblaze: add Emac ethernet driver
Best regards,
Wolfgang Denk
Hi Wolfgang,
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
For Ben. Can you look at drivers/net/xilinx_emac.c and xilinx_emaclite.c?
Signed-off-by: Michal Simek monstr@monstr.eu
I see you sneaked this in via your microblaze custodian repo. This was a Bad Thing, and I ask you not to do such things. You were supposed to run this through the Net custodian.
Sorry for that. Explanation is above.
Ditto for [PATCH 05/13] microblaze: add Emac ethernet driver
Best regards,
Wolfgang Denk
Best regards, Michal Simek
Dear Michal,
in message 4802FF86.8010504@seznam.cz you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
Best regards,
Wolfgang Denk
On Mon, Apr 14, 2008 at 3:50 PM, Wolfgang Denk wd@denx.de wrote:
Dear Michal,
in message 4802FF86.8010504@seznam.cz you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
I did see these patches, but haven't reviewed yet. I'll have a look in the next couple of days and will provide feedback.
regards, Ben
Hi Ben,
Dear Michal,
in message 4802FF86.8010504@seznam.cz you wrote:
this code was sent to mailing list I think twice. I think Grant reviewed this code once, didn't he?
Maybe, I don't remember the details. But if Ben had accepted the patch, he would have checked it into the u-boot-net custodian repository, where network stuff belongs to.
It should not go through other repositories normally (unless Ben gives his explicit permission).
I did see these patches, but haven't reviewed yet. I'll have a look in the next couple of days and will provide feedback.
regards, Ben
Thanks for it,
Michal Simek
participants (3)
-
Ben Warren -
Michal Simek -
Wolfgang Denk