[U-Boot] [PATCH] tools: correct proftool build rule
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Tom Rini trini@ti.com Cc: Simon Glass sjg@chromium.org --- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index 323d408..602b2e5 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -59,7 +59,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX)
# Source files which exist outside the tools directory EXT_OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += common/env_embedded.o @@ -182,7 +182,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
-$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
Hi Ian,
On 31 January 2014 10:09, Ian Campbell ijc@hellion.org.uk wrote:
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Tom Rini trini@ti.com Cc: Simon Glass sjg@chromium.org
It looks correct but does not apply for me on master.
Regards, Simon
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Tom Rini trini@ti.com Cc: Simon Glass sjg@chromium.org --- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index 328cea3..052e4d4 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX) BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
# Source files which exist outside the tools directory @@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
-$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
On 31 January 2014 16:54, Ian Campbell ijc@hellion.org.uk wrote:
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Tom Rini trini@ti.com Cc: Simon Glass sjg@chromium.org
Thanks Ian.
Acked-by: Simon Glass sjg@chromium.org
tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile b/tools/Makefile index 328cea3..052e4d4 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX) BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
# Source files which exist outside the tools directory @@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
-$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
-- 1.8.5.3
On Fri, Jan 31, 2014 at 11:54:44PM +0000, Ian Campbell wrote:
The incorrect substitution made it rebuild every time.
Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Tom Rini trini@ti.com Cc: Simon Glass sjg@chromium.org Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Ian Campbell -
Simon Glass -
Tom Rini