[U-Boot] [PATCH 1/1] efi_selftest: correctly check return values

When cancelling the timer we should check the return value provided by the set_timer service.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- lib/efi_selftest/efi_selftest_events.c | 2 +- lib/efi_selftest/efi_selftest_tpl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/efi_selftest/efi_selftest_events.c b/lib/efi_selftest/efi_selftest_events.c index b2cdc150da..081f31257f 100644 --- a/lib/efi_selftest/efi_selftest_events.c +++ b/lib/efi_selftest/efi_selftest_events.c @@ -186,7 +186,7 @@ static int execute(void) return EFI_ST_FAILURE; } ret = boottime->set_timer(event_wait, EFI_TIMER_STOP, 0); - if (index != 0) { + if (ret != EFI_SUCCESS) { efi_st_error("Could not cancel timer\n"); return EFI_ST_FAILURE; } diff --git a/lib/efi_selftest/efi_selftest_tpl.c b/lib/efi_selftest/efi_selftest_tpl.c index b8c0e70262..ddb67ed268 100644 --- a/lib/efi_selftest/efi_selftest_tpl.c +++ b/lib/efi_selftest/efi_selftest_tpl.c @@ -207,7 +207,7 @@ static int execute(void) return EFI_ST_FAILURE; } ret = boottime->set_timer(event_wait, EFI_TIMER_STOP, 0); - if (index != 0) { + if (ret != EFI_SUCCESS) { efi_st_error("Could not cancel timer\n"); return EFI_ST_FAILURE; }

On 13 October 2017 at 01:00, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
When cancelling the timer we should check the return value provided by the set_timer service.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
lib/efi_selftest/efi_selftest_events.c | 2 +- lib/efi_selftest/efi_selftest_tpl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Although I favour:
if (ref)
instead of:
if (ret != EFI_SUCCESS)
0 is the standard value for success in U-Boot.
Regards, Simon
participants (2)
-
Heinrich Schuchardt
-
Simon Glass