[U-Boot] [PATCH] env: Fix operation of 'make environ'

This was broken by the recent environment refactoring. Specifically:
$ make environ scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop. make: *** [Makefile:1469: environ] Error 2
Fix this by updating the Makefile and adjusting the #include filesnames in two C files.
Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ') Reported-by: Måns Rullgård mans@mansr.com Signed-off-by: Simon Glass sjg@chromium.org ---
Makefile | 2 +- tools/env/env_attr.c | 2 +- tools/env/env_flags.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index a0f3bfd2a5..dd9d567811 100644 --- a/Makefile +++ b/Makefile @@ -1466,7 +1466,7 @@ checkarmreloc: u-boot fi
environ: scripts_basic - $(Q)$(MAKE) $(build)=tools/$@ + $(Q)$(MAKE) $(build)=tools/env
tools-only: scripts_basic $(version_h) $(timestamp_h) $(Q)$(MAKE) $(build)=tools diff --git a/tools/env/env_attr.c b/tools/env/env_attr.c index 502d4c900b..4d8536335c 100644 --- a/tools/env/env_attr.c +++ b/tools/env/env_attr.c @@ -1 +1 @@ -#include "../../common/env_attr.c" +#include "../../env/attr.c" diff --git a/tools/env/env_flags.c b/tools/env/env_flags.c index b261cb8e39..71e13e2021 100644 --- a/tools/env/env_flags.c +++ b/tools/env/env_flags.c @@ -1 +1 @@ -#include "../../common/env_flags.c" +#include "../../env/flags.c"

Hi Simon,
On Tue, Aug 29, 2017 at 2:53 PM, Simon Glass sjg@chromium.org wrote:
This was broken by the recent environment refactoring. Specifically:
$ make environ scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop. make: *** [Makefile:1469: environ] Error 2
Fix this by updating the Makefile and adjusting the #include filesnames in two C files.
Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ') Reported-by: Måns Rullgård mans@mansr.com Signed-off-by: Simon Glass sjg@chromium.org
I assume this was an accident. There is nothing different about this since the last time.
Cheers, -Joe

Hi Joe,
On 30 August 2017 at 04:02, Joe Hershberger joe.hershberger@ni.com wrote:
Hi Simon,
On Tue, Aug 29, 2017 at 2:53 PM, Simon Glass sjg@chromium.org wrote:
This was broken by the recent environment refactoring. Specifically:
$ make environ scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop. make: *** [Makefile:1469: environ] Error 2
Fix this by updating the Makefile and adjusting the #include filesnames in two C files.
Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ') Reported-by: Måns Rullgård mans@mansr.com Signed-off-by: Simon Glass sjg@chromium.org
I assume this was an accident. There is nothing different about this since the last time.
Sorry, yes, please ignore.
Regards, Simon
participants (2)
-
Joe Hershberger
-
Simon Glass