[PATCH] cmd: Add Kconfig option for multiprocessor cmds
From: Ashok Reddy Soma ashok.reddy.soma@xilinx.com
Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
Signed-off-by: Ashok Reddy Soma ashok.reddy.soma@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com ---
cmd/Kconfig | 8 ++++++++ cmd/Makefile | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e438f..1e3eef4437b5 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1827,6 +1827,14 @@ config MP different processors in multiprocessor cases.
+config CMD_MP + bool "support for multiprocessor commands" + depends on MP + default y + help + This enables commands to bringup different processors + in multiprocessor cases. + config CMD_TIMER bool "timer" help diff --git a/cmd/Makefile b/cmd/Makefile index 891819ae0f6b..9e8074bb7e49 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o obj-$(CONFIG_CMD_SLEEP) += sleep.o obj-$(CONFIG_CMD_MMC) += mmc.o obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o -obj-$(CONFIG_MP) += mp.o +obj-$(CONFIG_CMD_MP) += mp.o obj-$(CONFIG_CMD_MTD) += mtd.o obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o obj-$(CONFIG_CMD_CLONE) += clone.o
On Fri, Jan 14, 2022 at 01:07:34PM +0100, Michal Simek wrote:
From: Ashok Reddy Soma ashok.reddy.soma@xilinx.com
Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
Signed-off-by: Ashok Reddy Soma ashok.reddy.soma@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
cmd/Kconfig | 8 ++++++++ cmd/Makefile | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e438f..1e3eef4437b5 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1827,6 +1827,14 @@ config MP different processors in multiprocessor cases.
+config CMD_MP
- bool "support for multiprocessor commands"
- depends on MP
- default y
- help
This enables commands to bringup different processorsin multiprocessor cases.config CMD_TIMER bool "timer" help diff --git a/cmd/Makefile b/cmd/Makefile index 891819ae0f6b..9e8074bb7e49 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o obj-$(CONFIG_CMD_SLEEP) += sleep.o obj-$(CONFIG_CMD_MMC) += mmc.o obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o -obj-$(CONFIG_MP) += mp.o +obj-$(CONFIG_CMD_MP) += mp.o obj-$(CONFIG_CMD_MTD) += mtd.o obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o obj-$(CONFIG_CMD_CLONE) += clone.o
The problem is that there's already an entry for MP in cmd/Kconfig. So yes, it should be fixed for consistency, but the current entry renamed/moved. Thanks!
On 1/14/22 21:00, Tom Rini wrote:
On Fri, Jan 14, 2022 at 01:07:34PM +0100, Michal Simek wrote:
From: Ashok Reddy Soma ashok.reddy.soma@xilinx.com
Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
Signed-off-by: Ashok Reddy Soma ashok.reddy.soma@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
cmd/Kconfig | 8 ++++++++ cmd/Makefile | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e438f..1e3eef4437b5 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1827,6 +1827,14 @@ config MP different processors in multiprocessor cases.
+config CMD_MP
- bool "support for multiprocessor commands"
- depends on MP
- default y
- help
This enables commands to bringup different processorsin multiprocessor cases.- config CMD_TIMER bool "timer" help
diff --git a/cmd/Makefile b/cmd/Makefile index 891819ae0f6b..9e8074bb7e49 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o obj-$(CONFIG_CMD_SLEEP) += sleep.o obj-$(CONFIG_CMD_MMC) += mmc.o obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o -obj-$(CONFIG_MP) += mp.o +obj-$(CONFIG_CMD_MP) += mp.o obj-$(CONFIG_CMD_MTD) += mtd.o obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o obj-$(CONFIG_CMD_CLONE) += clone.o
The problem is that there's already an entry for MP in cmd/Kconfig. So yes, it should be fixed for consistency, but the current entry renamed/moved. Thanks!
Consistency is one part. Second part is that MP code can be called without any command that's why having two symbols make sense. Anyway I have sent v2 with moving MP to Kconfig.
Thanks, Michal
participants (2)
-
Michal Simek -
Tom Rini