[U-Boot] [PATCH 03/34] zynq: Cleanup on miscellaneous configs

Cleanup on miscellaneous configurable options: - Rename SYS_PROMPT as "zynq-uboot" - Add comment - Re-order configs
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com --- include/configs/zynq.h | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/include/configs/zynq.h b/include/configs/zynq.h index 6ac1350..f9a071d 100644 --- a/include/configs/zynq.h +++ b/include/configs/zynq.h @@ -111,19 +111,21 @@ CONFIG_SYS_INIT_RAM_SIZE - \ GENERATED_GBL_DATA_SIZE)
-#define CONFIG_SYS_PROMPT "U-Boot> " -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ +/* Miscellaneous configurable options */ +#define CONFIG_SYS_PROMPT "zynq-uboot> " +#define CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " + +#define CONFIG_CMDLINE_EDITING +#define CONFIG_AUTO_COMPLETE +#define CONFIG_SYS_LONGHELP +#define CONFIG_SYS_MAXARGS 15 /* max number of command args */ +#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16)
#define CONFIG_SYS_LOAD_ADDR 0 -#define CONFIG_SYS_MAXARGS 15 /* max number of command args */ -#define CONFIG_SYS_LONGHELP -#define CONFIG_AUTO_COMPLETE -#define CONFIG_CMDLINE_EDITING
-#define CONFIG_SYS_HUSH_PARSER -#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
/* OF */ #define CONFIG_FIT

On Tue, Nov 05, 2013 at 11:16:24PM +0530, Jagannadha Sutradharudu Teki wrote:
-#define CONFIG_SYS_PROMPT "U-Boot> "
I'm not a fan of removing generic looking prompts, we should rely on other things to determine what we're on.
+#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
Not needed now, this is the default.

On 11/05/2013 08:45 PM, Tom Rini wrote:
On Tue, Nov 05, 2013 at 11:16:24PM +0530, Jagannadha Sutradharudu Teki wrote:
-#define CONFIG_SYS_PROMPT "U-Boot> "
I'm not a fan of removing generic looking prompts, we should rely on other things to determine what we're on.
Isn't it this generic looking prompt?
include/config_fallbacks.h:56:#ifndef CONFIG_SYS_PROMPT include/config_fallbacks.h:57:#define CONFIG_SYS_PROMPT "=> "
+#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
Not needed now, this is the default.
yep.
Thanks, Michal
participants (3)
-
Jagannadha Sutradharudu Teki
-
Michal Simek
-
Tom Rini