[BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig and booting from SPI flash I get:
U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50) Missing DTB ### ERROR ### Please RESET the board ###
Bisecting points to:
commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532 Author: Simon Glass sjg@chromium.org Date: Wed Jan 13 20:29:49 2021 -0700
fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
This setting may be different in SPL and TPL. Update the code to check the correct setting.
Signed-off-by: Simon Glass sjg@chromium.org
lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reverting this commit fixes booting.
On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig and booting from SPI flash I get:
U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50) Missing DTB ### ERROR ### Please RESET the board ###
Bisecting points to:
commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532 Author: Simon Glass sjg@chromium.org Date: Wed Jan 13 20:29:49 2021 -0700
fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup() This setting may be different in SPL and TPL. Update the code to check the correct setting. Signed-off-by: Simon Glass <sjg@chromium.org>lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reverting this commit fixes booting.
Thanks for the report. I'm about to push a revert for this and I'll add a Reported-by from you.
Hi,
On Mon, 15 Feb 2021 at 08:11, Tom Rini trini@konsulko.com wrote:
On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig and booting from SPI flash I get:
U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50) Missing DTB ### ERROR ### Please RESET the board ###
Bisecting points to:
commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532 Author: Simon Glass sjg@chromium.org Date: Wed Jan 13 20:29:49 2021 -0700
fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup() This setting may be different in SPL and TPL. Update the code to check the correct setting. Signed-off-by: Simon Glass <sjg@chromium.org>lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reverting this commit fixes booting.
Thanks for the report. I'm about to push a revert for this and I'll add a Reported-by from you.
I'm not sure what is going on here, but possibly we need to add TPL_SEPARATE_BSS to the board config..
Regards, Simon
On Wed, Feb 17, 2021 at 09:45:44PM -0700, Simon Glass wrote:
Hi,
On Mon, 15 Feb 2021 at 08:11, Tom Rini trini@konsulko.com wrote:
On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig and booting from SPI flash I get:
U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50) Missing DTB ### ERROR ### Please RESET the board ###
Bisecting points to:
commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532 Author: Simon Glass sjg@chromium.org Date: Wed Jan 13 20:29:49 2021 -0700
fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup() This setting may be different in SPL and TPL. Update the code to check the correct setting. Signed-off-by: Simon Glass <sjg@chromium.org>lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reverting this commit fixes booting.
Thanks for the report. I'm about to push a revert for this and I'll add a Reported-by from you.
I'm not sure what is going on here, but possibly we need to add TPL_SEPARATE_BSS to the board config..
Yes, that's the most likely case, I'm just not sure if we can progmatically figure out what platforms are missing it.
participants (3)
-
Markus Reichl -
Simon Glass -
Tom Rini