-----Original Message----- From: Ajay Bhargav [mailto:ajay.bhargav@einfochips.com] Sent: Friday, July 22, 2011 3:34 PM To: Lei Wen Cc: Prafulla Wadaskar; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v2 2/2] gpio: Add GPIO driver for Marvell SoC Armada100

Hi Lei, Thank you for confirming.

...

What do you mean by "changed back to Armada100 gpio"?

Well just incase GPIO register set is different for different archs this current driver need to be renamed as armada100 gpio.

So if other Marvell SoCs are having similar register set then we can have a common gpio header file like earlier version of this patch "mvgpio.h"

The main objective of having mvgpio.c is to share/reuse a driver code across several SoCs.

If most of the SoCs (what we know) have similar register definition, it makes sense to keep them in mvgpio.c

What may differ for each SOC is that- base addresses, number of GPIOs, number of GPIO Banks, that should go in asm/arch/gpio.h

If any future SoC follows totally different GPIO architecture, we can always have <soc_name>_gpio.c.

Regards.. Prafulla . .

Regards, Ajay Bhargav