[U-Boot-Users] please pull u-boot-sparc.git master
Wolfgang,
Please pull sparc. u-boot-sparc.git master.
I have added support for LEON2 and LEON3 SPARC processors and their simmulators. I have summarized some SPARC/LEON info below, I hope you find it usefull. Tried to make a short comment for all the patches, I think most of them are pretty obvious anyway.
git://www.denx.de/git/u-boot-sparc.git sparc is my testing branch.
ABOUT LEON3 and GRLIB --------------------- LEON3 is an open source (GPL) SPARC V7 and/or V8 processor part of GRLIB. GRLIB is a free comprehensive open source (GPL) Portable IP library (written in VHDL) featuring cores such as Ethernet 10/100/1000, SpaceWire, PCI, CAN, 1553, I2C, USB 1.1 and 2.0, SPI, DMA ATA, SVGA, PS/2, UART, Timer, SDRAM, SRAM, SSRAM, DDR, DDR2, FLASH/PROM, CPU Debug Unit, FPU, GPIO and many more. More info available at www.gaisler.com.
ABOUT SPARC-ELF COMPILER ------------------------ Compiling u-boot for LEON3 and LEON2 has only been has only been tested with GCC 3.4.4 compiler with added LEON2 and LEON3 support available from www.gaisler.com or ftp://ftp.gaisler.com/gaisler.com/bcc/bin/linux/sparc-elf-3.4.4-1.0.30.tar.bz2,
installation instructions can be found in bcc/doc/bcc.pdf. (extract to /opt/ and add /opt/sparc-elf-3.4.4/bin to PATH).
U-BOOT support tested --------------------- - LEON3 (and LEON3FT Fault tolerant version) - LEON3 Simmulator (GRSIM and TSIM) - LEON2 Simmulator (GRSIM and TSIM) - Network (GRETH and SMC91111 and USB) - USB 1.1 (UHCI) - Linux and RTEMS booting - booting UBOOT from RAM and FLASH by changing board/gaisler/xxx/config.mk - DDR, DDR2, SRAM, FT-SRAM - UART, IRQ, Timer
U-BOOT Patches and Repository -----------------------------
* Changes to Common code for SPARC Added SPARC images reqognition to bootm, added SPARC board information (bdinfo), fixed missleading #error information for CFG_ENV_IS_NOWHERE, SPARc has read 64-bit in Flash CFI driver. common/cmd_bdinfo.c | 31 +++++++++++++++++++++++++++++++ common/cmd_bootm.c | 2 ++ common/cmd_nvedit.c | 2 +- drivers/mtd/cfi_flash.c | 4 ++++ 4 files changed, 38 insertions(+), 1 deletions(-)
* SPARC, LEON3, LEON2 Support README | 3 + cpu/leon2/Makefile | 54 ++ cpu/leon2/config.mk | 26 + cpu/leon2/cpu.c | 59 ++ cpu/leon2/cpu_init.c | 133 ++++ cpu/leon2/interrupts.c | 219 +++++++ cpu/leon2/prom.c | 1062 ++++++++++++++++++++++++++++++++ cpu/leon2/serial.c | 138 +++++ cpu/leon2/start.S | 657 ++++++++++++++++++++ cpu/leon3/Makefile | 54 ++ cpu/leon3/ambapp.c | 380 ++++++++++++ cpu/leon3/config.mk | 26 + cpu/leon3/cpu.c | 60 ++ cpu/leon3/cpu_init.c | 256 ++++++++ cpu/leon3/interrupts.c | 222 +++++++ cpu/leon3/prom.c | 1099 +++++++++++++++++++++++++++++++++ cpu/leon3/serial.c | 145 +++++ cpu/leon3/start.S | 601 ++++++++++++++++++ cpu/leon3/usb_uhci.c | 1271 +++++++++++++++++++++++++++++++++++++++ cpu/leon3/usb_uhci.h | 184 ++++++ examples/Makefile | 3 + examples/sparc.lds | 61 ++ examples/stubs.c | 16 + include/asm-sparc/asi.h | 137 +++++ include/asm-sparc/asmmacro.h | 45 ++ include/asm-sparc/atomic.h | 29 + include/asm-sparc/bitops.h | 32 + include/asm-sparc/byteorder.h | 73 +++ include/asm-sparc/cache.h | 113 ++++ include/asm-sparc/errno.h | 162 +++++ include/asm-sparc/global_data.h | 97 +++ include/asm-sparc/io.h | 95 +++ include/asm-sparc/irq.h | 43 ++ include/asm-sparc/leon.h | 37 ++ include/asm-sparc/leon2.h | 237 ++++++++ include/asm-sparc/leon3.h | 40 ++ include/asm-sparc/machines.h | 92 +++ include/asm-sparc/page.h | 43 ++ include/asm-sparc/posix_types.h | 134 ++++ include/asm-sparc/processor.h | 118 ++++ include/asm-sparc/prom.h | 300 +++++++++ include/asm-sparc/psr.h | 109 ++++ include/asm-sparc/ptrace.h | 181 ++++++ include/asm-sparc/srmmu.h | 311 ++++++++++ include/asm-sparc/stack.h | 163 +++++ include/asm-sparc/string.h | 55 ++ include/asm-sparc/types.h | 71 +++ include/asm-sparc/u-boot.h | 74 +++ include/asm-sparc/winmacro.h | 151 +++++ lib_sparc/Makefile | 45 ++ lib_sparc/board.c | 525 ++++++++++++++++ lib_sparc/cache.c | 33 + lib_sparc/interrupts.c | 119 ++++ lib_sparc/sparc_linux.c | 228 +++++++ lib_sparc/time.c | 72 +++ sparc_config.mk | 24 + 56 files changed, 10717 insertions(+), 0 deletions(-)
* LEON3 boards and simulator, LEON2 simulator MAKEALL | 7 + Makefile | 36 +++- board/gaisler/gr_cpci_ax2000/Makefile | 52 ++++ board/gaisler/gr_cpci_ax2000/config.mk | 37 +++ board/gaisler/gr_cpci_ax2000/gr_cpci_ax2000.c | 58 ++++ board/gaisler/gr_cpci_ax2000/u-boot.lds | 160 ++++++++++ board/gaisler/gr_ep2s60/Makefile | 52 ++++ board/gaisler/gr_ep2s60/config.mk | 35 +++ board/gaisler/gr_ep2s60/gr_ep2s60.c | 58 ++++ board/gaisler/gr_ep2s60/u-boot.lds | 160 ++++++++++ board/gaisler/gr_xc3s_1500/Makefile | 52 ++++ board/gaisler/gr_xc3s_1500/config.mk | 34 ++ board/gaisler/gr_xc3s_1500/gr_xc3s_1500.c | 58 ++++ board/gaisler/gr_xc3s_1500/u-boot.lds | 162 ++++++++++ board/gaisler/grsim/Makefile | 50 +++ board/gaisler/grsim/config.mk | 34 ++ board/gaisler/grsim/grsim.c | 47 +++ board/gaisler/grsim/u-boot.lds | 161 ++++++++++ board/gaisler/grsim_leon2/Makefile | 50 +++ board/gaisler/grsim_leon2/config.mk | 34 ++ board/gaisler/grsim_leon2/grsim_leon2.c | 48 +++ board/gaisler/grsim_leon2/u-boot.lds | 159 ++++++++++ include/configs/gr_cpci_ax2000.h | 398 +++++++++++++++++++++++++ include/configs/gr_ep2s60.h | 347 +++++++++++++++++++++ include/configs/grsim.h | 387 ++++++++++++++++++++++++ include/configs/grsim_leon2.h | 378 +++++++++++++++++++++++ include/configs/grxc3s1500.h | 334 +++++++++++++++++++++ 27 files changed, 3387 insertions(+), 1 deletions(-)
* AMBA Plug&Play BUS Command, makes u-boot able to list PnP information from command line (AMBA AHB Masters, AHB Slaves and APB Slaves: IRQ and addresses) common/Makefile | 1 + common/cmd_ambapp.c | 292 ++++++++++++++++++++++++++++++ include/ambapp.h | 443 ++++++++++++++++++++++++++++++++++++++++++++++ include/config_cmd_all.h | 1 + 4 files changed, 737 insertions(+), 0 deletions(-)
* LEON3 GRETH 10/100 Ethernet network driver. drivers/net/Makefile | 1 + drivers/net/greth.c | 644 ++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/net/greth.h | 97 ++++++++ net/eth.c | 4 + 4 files changed, 746 insertions(+), 0 deletions(-)
* LEON2/3 SMC91111 Network driver support, Added in and out macros only. drivers/net/smc91111.h | 74 +++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 73 insertions(+), 1 deletions(-)
Thanks, Daniel Hellstrom
In message 47D63F7B.2090002@gaisler.com you wrote:
Please pull sparc. u-boot-sparc.git master.
I have added support for LEON2 and LEON3 SPARC processors and their simmulators. I have summarized some SPARC/LEON info below, I hope you find it usefull. Tried to make a short comment for all the patches, I think most of them are pretty obvious anyway.
Um... I can't seem to find any of these patches in the mailing list archive? Did you post them for review?
Best regards,
Wolfgang Denk
Dear Daniel,
in message 47D63F7B.2090002@gaisler.com you wrote:
Please pull sparc. u-boot-sparc.git master.
I cannot do that, as the commits in your repo don't correspond to the patches that have been posted on the mailing list. THis makes it impossible for me to understand what has been acked or rejected.
- Changes to Common code for SPARC
Added SPARC images reqognition to bootm, added SPARC board information (bdinfo), fixed missleading #error information for CFG_ENV_IS_NOWHERE, SPARc has read 64-bit in Flash CFI driver. common/cmd_bdinfo.c | 31 +++++++++++++++++++++++++++++++ common/cmd_bootm.c | 2 ++ common/cmd_nvedit.c | 2 +- drivers/mtd/cfi_flash.c | 4 ++++ 4 files changed, 38 insertions(+), 1 deletions(-)
This summary does not really correspond to what I see in your repo, either ?
For example, in your repo I see:
5497218ac3c3 - SPARC: fixed so that bootm recognize SPARC uboot-Images.
This was posted on the mailing list as "[PATCH 1/8] SPARC: bootm SPARC support".
b38bc5de9ef4 - SPARC: flash_read64 now calls __raw_readq for SPARC.
This was posted on the mailing list as "[PATCH 2/8] SPARC: SPARC cfi-flash support for 64-bit reads".
I sent a review comment to this patch, which you did not follow up, and you didn't fix the code either.
Sorry, this is not the way things are supposed to work.
And by the way: you must noch check in this patch yourself. You gotta run this through the CFI custodian.
etc. etc.
I don't have the time to clean up this mess. Sorry, but please follow up the feedback to your patches on the mailing list first, get them through the other custodians where needed, and then reset your repository so it matches the (cleaned up) patches on the mailing list.
Sorry.
Best regards,
Wolfgang Denk
Hello Wolfgang,
You have already replied to the pull request, the pull request was incorrect I'm sorry for that, and the sparc repo has been update since.
I have read all your comments on the SPARC patches I sent (and I totally agree with you) and replied to one or two of them.
I havn't found the time yet to work with u-boot since I sent the 1..8 patches. So my repository is in the same state as when I sent the patches (not the pull request). I'm currently working with other projects that have a strict deadline, but as soon as I can I will continue my u-boot work. I believe cleaning up the mess (coding style), splitting up the patches and make the fixes mentioned on the list will go quite quick we I start working with it.
Best regards, Daniel Hellstrom
Wolfgang Denk wrote:
Dear Daniel,
in message 47D63F7B.2090002@gaisler.com you wrote:
Please pull sparc. u-boot-sparc.git master.
I cannot do that, as the commits in your repo don't correspond to the patches that have been posted on the mailing list. THis makes it impossible for me to understand what has been acked or rejected.
- Changes to Common code for SPARC
Added SPARC images reqognition to bootm, added SPARC board information (bdinfo), fixed missleading #error information for CFG_ENV_IS_NOWHERE, SPARc has read 64-bit in Flash CFI driver. common/cmd_bdinfo.c | 31 +++++++++++++++++++++++++++++++ common/cmd_bootm.c | 2 ++ common/cmd_nvedit.c | 2 +- drivers/mtd/cfi_flash.c | 4 ++++ 4 files changed, 38 insertions(+), 1 deletions(-)
This summary does not really correspond to what I see in your repo, either ?
For example, in your repo I see:
5497218ac3c3 - SPARC: fixed so that bootm recognize SPARC uboot-Images.
This was posted on the mailing list as "[PATCH 1/8] SPARC:bootm SPARC support".
b38bc5de9ef4 - SPARC: flash_read64 now calls __raw_readq for SPARC.
This was posted on the mailing list as "[PATCH 2/8] SPARC: SPARC cfi-flash support for 64-bit reads". I sent a review comment to this patch, which you did not follow up, and you didn't fix the code either.Sorry, this is not the way things are supposed to work.
And by the way: you must noch check in this patch yourself. You gotta run this through the CFI custodian.etc. etc.
I don't have the time to clean up this mess. Sorry, but please follow up the feedback to your patches on the mailing list first, get them through the other custodians where needed, and then reset your repository so it matches the (cleaned up) patches on the mailing list.
Sorry.
Best regards,
Wolfgang Denk
Dear Daniel,
in message 47E8D6C6.5080903@gaisler.com you wrote:
I havn't found the time yet to work with u-boot since I sent the 1..8 patches. So my repository is in the same state as when I sent the patches (not the pull request). I'm currently working with other projects that have a strict deadline, but as soon as I can I will continue my u-boot work. I believe cleaning up the mess (coding style), splitting up the patches and make the fixes mentioned on the list will go quite quick we I start working with it.
I see. I just wanted to remind you as we currently have the merge window open so changes can go in.
Best regards,
Wolfgang Denk
participants (2)
-
Daniel Hellstrom -
Wolfgang Denk