[PATCH v2 1/4] misc: make CONFIG_IRQ selectable for all platforms
From: Wasim Khan wasim.khan@nxp.com
UCLASS_IRQ driver is not Intel specific. Make CONFIG_IRQ selectable for all platforms.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Tested-by: Vladimir Oltean vladimir.oltean@nxp.com Reviewed-by: Simon Glass sjg@chromium.org --- Changes in v2: - Corrected typo in commit description
drivers/misc/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 29432ae7eb..5eab1ed9c6 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -211,10 +211,9 @@ config FSL_SEC_MON like software violations or hardware security violations.
config IRQ - bool "Intel Interrupt controller" - depends on X86 || SANDBOX + bool "Interrupt controller" help - This enables support for Intel interrupt controllers, including ITSS. + This enables support for interrupt controllers, including ITSS. Some devices have extra features, such as Apollo Lake. The device has its own uclass since there are several operations involved.
From: Wasim Khan wasim.khan@nxp.com
GIC_V3_ITS uses UCLASS_IRQ driver. Update Kconfig to select IRQ when GIC_V3_ITS is enabled.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org --- Changes in v2: - no change
arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index fbe90875ae..f8b4d422d9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -67,6 +67,7 @@ config GIC_V3_ITS bool "ARM GICV3 ITS" select REGMAP select SYSCON + select IRQ help ARM GICV3 Interrupt translation service (ITS). Basic support for programming locality specific peripheral
On Mon, Mar 08, 2021 at 04:48:14PM +0100, Wasim Khan wrote:
From: Wasim Khan wasim.khan@nxp.com
GIC_V3_ITS uses UCLASS_IRQ driver. Update Kconfig to select IRQ when GIC_V3_ITS is enabled.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Tested-by: Vladimir Oltean vladimir.oltean@nxp.com
Needs this patch to actually work properly, so that should be accepted as well: https://patchwork.ozlabs.org/project/uboot/patch/20210305070235.13547-1-Zhiq...
Changes in v2:
- no change
arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index fbe90875ae..f8b4d422d9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -67,6 +67,7 @@ config GIC_V3_ITS bool "ARM GICV3 ITS" select REGMAP select SYSCON
- select IRQ help ARM GICV3 Interrupt translation service (ITS). Basic support for programming locality specific peripheral
-- 2.25.1
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Wasim Khan Sent: Monday, March 8, 2021 9:18 PM To: sjg@chromium.org; bmeng.cn@gmail.com; mario.six@gdsys.cc; bharat.gooty@broadcom.com; rayagonda.kokatanur@broadcom.com; t- kristo@ti.com; Varun Sethi V.Sethi@nxp.com Cc: u-boot@lists.denx.de; Wasim Khan wasim.khan@nxp.com; Z.q. Hou zhiqiang.hou@nxp.com Subject: [PATCH v2 2/4] arch: arm: update Kconfig to select IRQ when GIC_V3_ITS is enabled
From: Wasim Khan wasim.khan@nxp.com
GIC_V3_ITS uses UCLASS_IRQ driver. Update Kconfig to select IRQ when GIC_V3_ITS is enabled.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- no change
arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index fbe90875ae..f8b4d422d9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -67,6 +67,7 @@ config GIC_V3_ITS bool "ARM GICV3 ITS" select REGMAP select SYSCON
- select IRQ help ARM GICV3 Interrupt translation service (ITS). Basic support for programming locality specific peripheral
-- 2.25.1
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com
Tom,
Kindly help to merge this patch. This is required to fix boot issue on many of NXP fsl-qoriq platforms like lx2160ardb.
Thanks Priyanka
On Mon, Mar 08, 2021 at 04:48:14PM +0100, Wasim Khan wrote:
From: Wasim Khan wasim.khan@nxp.com
GIC_V3_ITS uses UCLASS_IRQ driver. Update Kconfig to select IRQ when GIC_V3_ITS is enabled.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org Tested-by: Vladimir Oltean vladimir.oltean@nxp.com
Applied to u-boot/master, thanks!
From: Wasim Khan wasim.khan@nxp.com
use 'select' to enable IRQ as it does not have architecture specific dependency.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org --- Changes in v2: - no change
arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 3aa99e08fc..362b220948 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -167,6 +167,7 @@ config X86 select TIMER select USE_PRIVATE_LIBGCC select X86_TSC_TIMER + select IRQ imply HAS_ROM if X86_RESET_VECTOR imply BLK imply CMD_DM @@ -197,7 +198,6 @@ config X86 imply USB_HOST_ETHER imply PCH imply RTC_MC146818 - imply IRQ imply ACPIGEN if !QEMU imply SYSINFO if GENERATE_SMBIOS_TABLE imply SYSINFO_SMBIOS if GENERATE_SMBIOS_TABLE
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Wasim Khan Sent: Monday, March 8, 2021 9:18 PM To: sjg@chromium.org; bmeng.cn@gmail.com; mario.six@gdsys.cc; bharat.gooty@broadcom.com; rayagonda.kokatanur@broadcom.com; t- kristo@ti.com; Varun Sethi V.Sethi@nxp.com Cc: u-boot@lists.denx.de; Wasim Khan wasim.khan@nxp.com; Z.q. Hou zhiqiang.hou@nxp.com Subject: [PATCH v2 3/4] arch: Kconfig: enable IRQ using select for x86 architecture
From: Wasim Khan wasim.khan@nxp.com
use 'select' to enable IRQ as it does not have architecture specific dependency.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- no change
arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 3aa99e08fc..362b220948 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -167,6 +167,7 @@ config X86 select TIMER select USE_PRIVATE_LIBGCC select X86_TSC_TIMER
- select IRQ imply HAS_ROM if X86_RESET_VECTOR imply BLK imply CMD_DM
@@ -197,7 +198,6 @@ config X86 imply USB_HOST_ETHER imply PCH imply RTC_MC146818
- imply IRQ imply ACPIGEN if !QEMU imply SYSINFO if GENERATE_SMBIOS_TABLE imply SYSINFO_SMBIOS if GENERATE_SMBIOS_TABLE
-- 2.25.1
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com
Tom,
Kindly help to merge this patch. This is required to fix boot issue on many of NXP fsl-qoriq platforms like lx2160ardb.
Thanks Priyanka
On Mon, Mar 08, 2021 at 04:48:15PM +0100, Wasim Khan wrote:
From: Wasim Khan wasim.khan@nxp.com
use 'select' to enable IRQ as it does not have architecture specific dependency.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
From: Wasim Khan wasim.khan@nxp.com
Enable IRQ using select for sandbox architecture.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Simon Glass sjg@chromium.org --- Changes in v2: - no change
arch/Kconfig | 1 + configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig index 362b220948..336a5a68ef 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -109,6 +109,7 @@ config SANDBOX select SPI select SUPPORT_OF_CONTROL select SYSRESET_CMD_POWEROFF + select IRQ imply BITREVERSE select BLOBLIST imply CMD_DM diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig index 5fbbfd7236..534f58f868 100644 --- a/configs/sandbox64_defconfig +++ b/configs/sandbox64_defconfig @@ -133,7 +133,6 @@ CONFIG_CROS_EC_I2C=y CONFIG_CROS_EC_LPC=y CONFIG_CROS_EC_SANDBOX=y CONFIG_CROS_EC_SPI=y -CONFIG_IRQ=y CONFIG_P2SB=y CONFIG_PWRSEQ=y CONFIG_SPL_PWRSEQ=y diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index f1ec701a9f..56f83695e0 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -160,7 +160,6 @@ CONFIG_CROS_EC_I2C=y CONFIG_CROS_EC_LPC=y CONFIG_CROS_EC_SANDBOX=y CONFIG_CROS_EC_SPI=y -CONFIG_IRQ=y CONFIG_P2SB=y CONFIG_PWRSEQ=y CONFIG_SPL_PWRSEQ=y diff --git a/configs/sandbox_flattree_defconfig b/configs/sandbox_flattree_defconfig index edca7f1808..8098d652dc 100644 --- a/configs/sandbox_flattree_defconfig +++ b/configs/sandbox_flattree_defconfig @@ -114,7 +114,6 @@ CONFIG_CROS_EC_I2C=y CONFIG_CROS_EC_LPC=y CONFIG_CROS_EC_SANDBOX=y CONFIG_CROS_EC_SPI=y -CONFIG_IRQ=y CONFIG_P2SB=y CONFIG_PWRSEQ=y CONFIG_SPL_PWRSEQ=y diff --git a/configs/sandbox_spl_defconfig b/configs/sandbox_spl_defconfig index 479f0226e3..0afb0bec34 100644 --- a/configs/sandbox_spl_defconfig +++ b/configs/sandbox_spl_defconfig @@ -134,7 +134,6 @@ CONFIG_CROS_EC_I2C=y CONFIG_CROS_EC_LPC=y CONFIG_CROS_EC_SANDBOX=y CONFIG_CROS_EC_SPI=y -CONFIG_IRQ=y CONFIG_P2SB=y CONFIG_PWRSEQ=y CONFIG_SPL_PWRSEQ=y
Hi Wasim,
On Tue, 9 Mar 2021 at 04:48, Wasim Khan wasim.khan@oss.nxp.com wrote:
From: Wasim Khan wasim.khan@nxp.com
Enable IRQ using select for sandbox architecture.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- no change
arch/Kconfig | 1 + configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)
You can see the status of your series here:
http://patchwork.ozlabs.org/project/uboot/list/?series=232773
It is assigned to Tom Rini.
Regards, Simon
Hi Tom,
-----Original Message----- From: Simon Glass sjg@chromium.org Sent: Tuesday, March 30, 2021 10:27 PM To: Wasim Khan (OSS) wasim.khan@oss.nxp.com Cc: Bin Meng bmeng.cn@gmail.com; Mario Six mario.six@gdsys.cc; Bharat Gooty bharat.gooty@broadcom.com; Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com; Tero Kristo t-kristo@ti.com; Varun Sethi V.Sethi@nxp.com; U-Boot Mailing List u-boot@lists.denx.de; Wasim Khan wasim.khan@nxp.com Subject: Re: [PATCH v2 4/4] sandbox: enable IRQ using select for sandbox architecture
Hi Wasim,
On Tue, 9 Mar 2021 at 04:48, Wasim Khan wasim.khan@oss.nxp.com wrote:
From: Wasim Khan wasim.khan@nxp.com
Enable IRQ using select for sandbox architecture.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- no change
arch/Kconfig | 1 + configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)
You can see the status of your series here:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwor k.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D232773&data=0 4%7C01%7Cwasim.khan%40nxp.com%7Cbabc6763976e4d9c257808d8f39cd77b %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637527202242089410 %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cmOzxfmhlIdP6A0G1P%2 BAXg%2FhPVky02%2BeUEMxd5y1bHs%3D&reserved=0
It is assigned to Tom Rini.
Regards, Simon
https://patchwork.ozlabs.org/project/uboot/list/?series=232773 this series is tested, reviewed. It can be merged after https://patchwork.ozlabs.org/project/uboot/patch/20210305070235.13547-1-Zhiq...
Kindly do the needful
Regards, Wasim
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Wasim Khan (OSS) Sent: Friday, April 16, 2021 1:52 PM To: Tom Rini trini@konsulko.com; Simon Glass sjg@chromium.org Cc: u-boot@lists.denx.de Subject: RE: [PATCH v2 4/4] sandbox: enable IRQ using select for sandbox architecture
Hi Tom,
-----Original Message----- From: Simon Glass sjg@chromium.org Sent: Tuesday, March 30, 2021 10:27 PM To: Wasim Khan (OSS) wasim.khan@oss.nxp.com Cc: Bin Meng bmeng.cn@gmail.com; Mario Six mario.six@gdsys.cc; Bharat Gooty bharat.gooty@broadcom.com; Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com; Tero Kristo t-kristo@ti.com; Varun Sethi V.Sethi@nxp.com; U-Boot Mailing List u-boot@lists.denx.de; Wasim Khan wasim.khan@nxp.com Subject: Re: [PATCH v2 4/4] sandbox: enable IRQ using select for sandbox architecture
Hi Wasim,
On Tue, 9 Mar 2021 at 04:48, Wasim Khan wasim.khan@oss.nxp.com
wrote:
From: Wasim Khan wasim.khan@nxp.com
Enable IRQ using select for sandbox architecture.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- no change
arch/Kconfig | 1 + configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)
You can see the status of your series here:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch wor
k.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D232773&data =0
4%7C01%7Cwasim.khan%40nxp.com%7Cbabc6763976e4d9c257808d8f39cd77b
%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63752720224208941
0
%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
LCJB
TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cmOzxfmhlIdP6A0G1P% 2
BAXg%2FhPVky02%2BeUEMxd5y1bHs%3D&reserved=0
It is assigned to Tom Rini.
Regards, Simon
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D232773&d ata=04%7C01%7Cpriyanka.jain%40nxp.com%7C7a5eea075a364cc3863d08d900 b0b077%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6375415811448 67361%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZBoZ4dxhQBW cFuR3E5zE0fQVb55e%2BxbWWxnFgyo411s%3D&reserved=0 this series is tested, reviewed. It can be merged after https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch work.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20210305070235.13547-1- Zhiqiang.Hou%40nxp.com%2F&data=04%7C01%7Cpriyanka.jain%40nxp.c om%7C7a5eea075a364cc3863d08d900b0b077%7C686ea1d3bc2b4c6fa92cd99c5 c301635%7C0%7C0%7C637541581144867361%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D %7C1000&sdata=%2FidlO6hAGlxGD1cO2fA5cQORDIorCY%2FPq%2FQkZQ 4pEm0%3D&reserved=0
Kindly do the needful
Regards, Wasim
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com
Tom,
Kindly help to merge this patch. This is required to fix boot issue on many of NXP fsl-qoriq platforms like lx2160ardb.
Thanks Priyanka
On Mon, Mar 08, 2021 at 04:48:16PM +0100, Wasim Khan wrote:
From: Wasim Khan wasim.khan@nxp.com
Enable IRQ using select for sandbox architecture.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Wasim Khan Sent: Monday, March 8, 2021 9:18 PM To: sjg@chromium.org; bmeng.cn@gmail.com; mario.six@gdsys.cc; bharat.gooty@broadcom.com; rayagonda.kokatanur@broadcom.com; t- kristo@ti.com; Varun Sethi V.Sethi@nxp.com Cc: u-boot@lists.denx.de; Wasim Khan wasim.khan@nxp.com; Vladimir Oltean vladimir.oltean@nxp.com Subject: [PATCH v2 1/4] misc: make CONFIG_IRQ selectable for all platforms
From: Wasim Khan wasim.khan@nxp.com
UCLASS_IRQ driver is not Intel specific. Make CONFIG_IRQ selectable for all platforms.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Tested-by: Vladimir Oltean vladimir.oltean@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Changes in v2:
- Corrected typo in commit description
drivers/misc/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 29432ae7eb..5eab1ed9c6 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -211,10 +211,9 @@ config FSL_SEC_MON like software violations or hardware security violations.
config IRQ
- bool "Intel Interrupt controller"
- depends on X86 || SANDBOX
- bool "Interrupt controller" help
This enables support for Intel interrupt controllers, including ITSS.
This enables support for interrupt controllers, including ITSS.-- 2.25.1
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com
Tom,
Kindly help to merge this patch. This is required to fix boot issue on many of NXP fsl-qoriq platforms like lx2160ardb.
Thanks Priyanka
On Mon, Mar 08, 2021 at 04:48:13PM +0100, Wasim Khan wrote:
From: Wasim Khan wasim.khan@nxp.com
UCLASS_IRQ driver is not Intel specific. Make CONFIG_IRQ selectable for all platforms.
Signed-off-by: Wasim Khan wasim.khan@nxp.com Tested-by: Vladimir Oltean vladimir.oltean@nxp.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (6)
-
Priyanka Jain -
Simon Glass -
Tom Rini -
Vladimir Oltean -
Wasim Khan -
Wasim Khan (OSS)