[PATCH] imx: imx8: fix build when CONFIG_IMX_BOOTAUX is set
From: Max Krummenacher max.krummenacher@toradex.com
Use correct function name.
Fixes: e8cd1f60d964 ("imx: imx8: bootaux: Add i.MX8 M4 boot support") Signed-off-by: Max Krummenacher max.krummenacher@toradex.com ---
arch/arm/mach-imx/imx8/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/imx8/cpu.c b/arch/arm/mach-imx/imx8/cpu.c index accba502e492..834aca82bcfd 100644 --- a/arch/arm/mach-imx/imx8/cpu.c +++ b/arch/arm/mach-imx/imx8/cpu.c @@ -258,14 +258,14 @@ int arch_auxiliary_core_up(u32 core_id, ulong boot_private_data) return -EIO; }
- if (!power_domain_lookup_name("audio_sai0", &pd)) { + if (!imx8_power_domain_lookup_name("audio_sai0", &pd)) { if (power_domain_on(&pd)) { printf("Error power on SAI0\n"); return -EIO; } }
- if (!power_domain_lookup_name("audio_ocram", &pd)) { + if (!imx8_power_domain_lookup_name("audio_ocram", &pd)) { if (power_domain_on(&pd)) { printf("Error power on HIFI RAM\n"); return -EIO;
Subject: [PATCH] imx: imx8: fix build when CONFIG_IMX_BOOTAUX is set
From: Max Krummenacher max.krummenacher@toradex.com
Use correct function name.
Fixes: e8cd1f60d964 ("imx: imx8: bootaux: Add i.MX8 M4 boot support") Signed-off-by: Max Krummenacher max.krummenacher@toradex.com
arch/arm/mach-imx/imx8/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/imx8/cpu.c b/arch/arm/mach- imx/imx8/cpu.c index accba502e492..834aca82bcfd 100644 --- a/arch/arm/mach-imx/imx8/cpu.c +++ b/arch/arm/mach-imx/imx8/cpu.c @@ -258,14 +258,14 @@ int arch_auxiliary_core_up(u32 core_id, ulong boot_private_data) return -EIO; }
if (!power_domain_lookup_name("audio_sai0", &pd)){
if (!imx8_power_domain_lookup_name("audio_sai0",&pd)) {
I think need to find a proper fix to this. This API is legacy API.
Thanks Peng
Hello Peng Fan On Thu, Aug 08, 2024 at 03:16:54AM +0000, Peng Fan wrote:
Subject: [PATCH] imx: imx8: fix build when CONFIG_IMX_BOOTAUX is set
From: Max Krummenacher max.krummenacher@toradex.com
Use correct function name.
Fixes: e8cd1f60d964 ("imx: imx8: bootaux: Add i.MX8 M4 boot support") Signed-off-by: Max Krummenacher max.krummenacher@toradex.com
arch/arm/mach-imx/imx8/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/imx8/cpu.c b/arch/arm/mach- imx/imx8/cpu.c index accba502e492..834aca82bcfd 100644 --- a/arch/arm/mach-imx/imx8/cpu.c +++ b/arch/arm/mach-imx/imx8/cpu.c @@ -258,14 +258,14 @@ int arch_auxiliary_core_up(u32 core_id, ulong boot_private_data) return -EIO; }
if (!power_domain_lookup_name("audio_sai0", &pd)){
if (!imx8_power_domain_lookup_name("audio_sai0",&pd)) {
I think need to find a proper fix to this. This API is legacy API.
The current code does call a function which does not exist. Thus the compile fails if enabling CONFIG_IMX_BOOTAUX for a i.MX 8X and likely always did. I think that would merrit fixing it now rather than waiting until the more modern API is ported into U-Boot and the code using it changed to the new API.
Alternatively I could remove the handling of the HiFi auxiliary core from arch_auxiliary_core_up() and returning EINVAL if someone tried to set that core up.
Regards Max
Thanks Peng
Hi Max,
On Thu, Aug 8, 2024 at 7:02 AM Max Krummenacher max.oss.09@gmail.com wrote:
The current code does call a function which does not exist. Thus the compile fails if enabling CONFIG_IMX_BOOTAUX for a i.MX 8X and likely always did. I think that would merrit fixing it now rather than waiting until the more modern API is ported into U-Boot and the code using it changed to the new API.
Agreed, applied it.
Peng, feel free to submit additional patches to address this issue.
participants (4)
-
Fabio Estevam -
Max Krummenacher -
max.oss.09＠gmail.com
-
Peng Fan