[U-Boot] [PATCH] cmd_nand: drop duplicate NULL ptr check
The first if statement checks for NULL ptrs, so there is no need to check it again in later else cases (such as .oob).
Signed-off-by: Mike Frysinger vapier@gentoo.org CC: Scott Wood scottwood@freescale.com --- common/cmd_nand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/cmd_nand.c b/common/cmd_nand.c index e142d76..ff5bc6e 100644 --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -390,7 +390,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) else ret = nand_write_skip_bad(nand, off, &size, (u_char *)addr); - } else if (s != NULL && !strcmp(s, ".oob")) { + } else if (!strcmp(s, ".oob")) { /* out-of-band data */ mtd_oob_ops_t ops = { .oobbuf = (u8 *)addr,
Dear Mike Frysinger,
In message 1239589760-19215-1-git-send-email-vapier@gentoo.org you wrote:
The first if statement checks for NULL ptrs, so there is no need to check it again in later else cases (such as .oob).
Signed-off-by: Mike Frysinger vapier@gentoo.org CC: Scott Wood scottwood@freescale.com
common/cmd_nand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Mike Frysinger -
Wolfgang Denk