[U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com --- drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index b18c75d..76fa0b0 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc) if (mmc->ddr_mode) regs |= DWMCI_DDR_MODE; else - regs &= DWMCI_DDR_MODE; + regs &= ~DWMCI_DDR_MODE;
dwmci_writel(host, DWMCI_UHS_REG, regs);
Hi
Could you check this patch?
Best Regards, Jaehoon Chung
On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index b18c75d..76fa0b0 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc) if (mmc->ddr_mode) regs |= DWMCI_DDR_MODE; else
regs &= DWMCI_DDR_MODE;
regs &= ~DWMCI_DDR_MODE;dwmci_writel(host, DWMCI_UHS_REG, regs);
Hi Jaehoon,
On Jan 23, 2015, at 15:43 , Jaehoon Chung jh80.chung@gmail.com wrote:
Hi
Could you check this patch?
Ugh, sorry missed this; did it end up assigned at patchwork to me?
The patch is obviously correct.
Best Regards, Jaehoon Chung
Regards
— Pantelis
On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index b18c75d..76fa0b0 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc) if (mmc->ddr_mode) regs |= DWMCI_DDR_MODE; else
regs &= DWMCI_DDR_MODE;
regs &= ~DWMCI_DDR_MODE;dwmci_writel(host, DWMCI_UHS_REG, regs);
Dear Pantelis.
On 01/23/2015 10:44 PM, Pantelis Antoniou wrote:
Hi Jaehoon,
On Jan 23, 2015, at 15:43 , Jaehoon Chung jh80.chung@gmail.com wrote:
Hi
Could you check this patch?
Ugh, sorry missed this; did it end up assigned at patchwork to me?
Updated. :)
Best Regards, Jaehoon Chung
The patch is obviously correct.
Best Regards, Jaehoon Chung
Regards
— Pantelis
On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index b18c75d..76fa0b0 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc) if (mmc->ddr_mode) regs |= DWMCI_DDR_MODE; else
regs &= DWMCI_DDR_MODE;
regs &= ~DWMCI_DDR_MODE;dwmci_writel(host, DWMCI_UHS_REG, regs);
Hi Jaehoon,
On Jan 14, 2015, at 10:37 , Jaehoon Chung jh80.chung@samsung.com wrote:
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index b18c75d..76fa0b0 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc) if (mmc->ddr_mode) regs |= DWMCI_DDR_MODE; else
regs &= DWMCI_DDR_MODE;
regs &= ~DWMCI_DDR_MODE;dwmci_writel(host, DWMCI_UHS_REG, regs);
-- 1.9.1
Applied, thanks
— Pantelis
participants (4)
-
Jaehoon Chung -
Jaehoon Chung -
Pantelis Antoniou -
Pantelis Antoniou