[U-Boot] [PATCH] rsa: reject images with unknown padding

Previously we would store NULL in info->padding and jump to an illegal instruction if an unknown value for "padding" was specified in the device tree.
Signed-off-by: Patrick Doyle pdoyle@irobot.com --- common/image-sig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/image-sig.c b/common/image-sig.c index 4f6b4ec..004fbc5 100644 --- a/common/image-sig.c +++ b/common/image-sig.c @@ -211,7 +211,7 @@ static int fit_image_setup_verify(struct image_sign_info *info, info->required_keynode = required_keynode; printf("%s:%s", algo_name, info->keyname);
- if (!info->checksum || !info->crypto) { + if (!info->checksum || !info->crypto || !info->padding) { *err_msgp = "Unknown signature algorithm"; return -1; }

On Fri, Jun 14, 2019 at 01:43:38PM -0400, Patrick Doyle wrote:
Previously we would store NULL in info->padding and jump to an illegal instruction if an unknown value for "padding" was specified in the device tree.
Signed-off-by: Patrick Doyle pdoyle@irobot.com
Applied to u-boot/master, thanks!
participants (2)
-
Patrick Doyle
-
Tom Rini