[U-Boot] [PATCH] rockchip: dts: rk3399: Add spl-boot-order for Rock PI 4
RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.
Signed-off-by: Andy Yan andy.yan@rock-chips.com ---
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi index 7bddc3acdb..30f2b5f479 100644 --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi @@ -4,3 +4,8 @@ */
#include "rk3399-u-boot.dtsi" +/ { + chosen { + u-boot,spl-boot-order = &sdhci, &sdmmc; + }; +};
From: Andy Yan andy.yan@rock-chips.com Date: Thu, 4 Jul 2019 14:52:47 +0800
RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.
Do you really not want "same-as-spl" in there as well?
Signed-off-by: Andy Yan andy.yan@rock-chips.com
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi index 7bddc3acdb..30f2b5f479 100644 --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi @@ -4,3 +4,8 @@ */
#include "rk3399-u-boot.dtsi" +/ {
- chosen {
u-boot,spl-boot-order = &sdhci, &sdmmc;- };
+};
2.17.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Hi Mark:
Mark Kettenis mark.kettenis@xs4all.nl 于2019年7月4日周四 下午3:16写道：
From: Andy Yan andy.yan@rock-chips.com Date: Thu, 4 Jul 2019 14:52:47 +0800
RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.
Do you really not want "same-as-spl" in there as well?
same-as-spl can be added as a feather with another patch. But this patch should be applied first as a fix, or the board can't bootup when there is no sdcard on board.
Signed-off-by: Andy Yan andy.yan@rock-chips.com
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
index 7bddc3acdb..30f2b5f479 100644 --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi @@ -4,3 +4,8 @@ */
#include "rk3399-u-boot.dtsi" +/ {
chosen {u-boot,spl-boot-order = &sdhci, &sdmmc;};+};
2.17.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Hi Andy,
On 2019/7/4 下午2:52, Andy Yan wrote:
RK3399 use sdhci for eMMC and DW MMC for SD Card, and spl will only try to boot from SDMMC if we don't specify other boot device for spl-boot-order. So add sdhci and sdmmc for spl-boot-order here.
Signed-off-by: Andy Yan andy.yan@rock-chips.com
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks,
- Kever
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi index 7bddc3acdb..30f2b5f479 100644 --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi @@ -4,3 +4,8 @@ */
#include "rk3399-u-boot.dtsi" +/ {
- chosen {
u-boot,spl-boot-order = &sdhci, &sdmmc;- };
+};
participants (4)
-
Andy Yan -
Andy Yan -
Kever Yang -
Mark Kettenis