[U-Boot-Users] [PATCH v2] IDE: fix bug in reset sequence

According to the ata (ata5) specification the RESET- signal shall be asserted for at least 25 us. Without this patch, the RESET- signal is asserted on some boards for only < 1 us (e. g. on the TQM5200). This patch adds a general delay of 25 us to the RESET- signal.
Without this patch a Platinum 4 GiB CF card is not recognised properly on boards with a TQM5200 (STK52xx, TB5200).
The patch was tested on the boards TQM5200, TQM200B and TB5200 (with MPC5200 cpu) with the following IDE Hardware:
- 128 MiB CF Toshiba THNCF128MDG - 128 MiB CF Toshiba THNCF128MBA - 4 GiB CF InnoDisk iSmart iCF2000+ - 4 GiB CF SMI 20070312 (labeled with Platinum) - 4 GiB CF Sony NCFB4G - 40 GiB HDD Hitachi Travelstar IC25N040ATCS0-4
Signed-off-by: Martin Krause martin.krause@tqs.de --- Hi Jean-Christophe,
thanks for your response! I've tested the patch with all IDE devices I found. It would be great if someone else could test this on some other hardware.
Regards, Martin ---
common/cmd_ide.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/common/cmd_ide.c b/common/cmd_ide.c index 8ace970..2d47914 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -1529,6 +1529,9 @@ static void ide_reset (void)
ide_set_reset (1); /* assert reset */
+ /* the reset signal shall be asserted for at least 25 us */ + udelay(25); + WATCHDOG_RESET();
#ifdef CFG_PB_12V_ENABLE

In message 20080404130906.24594.85188.stgit@tq-sewsrv-4.tq-net.de you wrote:
According to the ata (ata5) specification the RESET- signal shall be asserted for at least 25 us. Without this patch, the RESET- signal is asserted on some boards for only < 1 us (e. g. on the TQM5200). This patch adds a general delay of 25 us to the RESET- signal.
Already applied.
If you want to send follow-ups to previous postings. please make sure to keep the reference information intact. As is, it was impossible to me to see that this message belonged to a previous posting (and, even worse, I didn't see that there was a follow-up to the one I checked in).
Best regards,
Wolfgang Denk

u-boot-users-bounces@lists.sourceforge.net wrote on :
In message 20080404130906.24594.85188.stgit@tq-sewsrv-4.tq-net.de you wrote:
According to the ata (ata5) specification the RESET- signal shall be asserted for at least 25 us. Without this patch, the RESET- signal is asserted on some boards for only < 1 us (e. g. on the TQM5200). This patch adds a general delay of 25 us to the RESET- signal.
Already applied.
If you want to send follow-ups to previous postings. please make sure to keep the reference information intact. As is, it was impossible to
I'm sorry for that! I tried to mark this patch as follup-up by the "v2" in the Subject, but I see, that this was not sufficient.
What do you mean with reference information? The message id? Does anyone know, how I can re-send a modified patch with git (or stacked git which I use normally) without generating a new message ID (and without copy- and pasteing the new patch in the reply email)?
Best Regards, Martin Krause
-- TQ-Systems GmbH Muehlstrasse 2, Gut Delling, D-82229 Seefeld Amtsgericht Muenchen, HRB 105 018, UST-IdNr. DE 811 607 913 Geschaeftsfuehrer: Dipl.-Ing. (FH) Detlef Schneider, Dipl.-Ing. (FH) Ruediger Stahl http://www.tq-group.com
participants (3)
-
Martin Krause
-
Martin Krause
-
Wolfgang Denk