Re: [U-Boot] [PATCH v2 2/3] OMAP3: pandora: remove unused config macros
On Fri, Nov 5, 2010 at 10:07 PM, Paulraj, Sandeep s-paulraj@ti.com wrote:
Pandora's config has various flash related macros that are either not referenced anywhere in the code or are used by drivers that are not enabled. Remove them.
Signed-off-by: Grazvydas Ignotas notasas@gmail.com
Alternatively this old patch can be applied to clean up more OMAP
boards:
http://lists.denx.de/pipermail/u-boot/2010-April/070860.html
Do you think this patch still applies clean?
It will be better if you repost to refresh us all.
Yes it still does, attaching for your convenience (with Steve's ack from June 9).
This does not apply. This is probably because I added your other patches
--Sandeep
On Fri, Nov 19, 2010 at 10:29 PM, Paulraj, Sandeep s-paulraj@ti.com wrote:
On Fri, Nov 5, 2010 at 10:07 PM, Paulraj, Sandeep s-paulraj@ti.com wrote:
Pandora's config has various flash related macros that are either not referenced anywhere in the code or are used by drivers that are not enabled. Remove them.
Signed-off-by: Grazvydas Ignotas notasas@gmail.com
Alternatively this old patch can be applied to clean up more OMAP
boards:
http://lists.denx.de/pipermail/u-boot/2010-April/070860.html
Do you think this patch still applies clean?
It will be better if you repost to refresh us all.
Yes it still does, attaching for your convenience (with Steve's ack from June 9).
This does not apply. This is probably because I added your other patches
Yeah this this was supposed to be applied instead of "OMAP3: pandora: remove unused config macros" (it covers pandora and other boards, you applied pandora-only version).
I see my email got mangled in u-boot-ti.git, could you fix it up if you haven't sent pull request yet? You could replace this patch with 2/3 along the way too (can be done easily with git rebase -i).
Dear Sandeep,
In message AANLkTikYMeERp9JXSS71+4Uv+WD38zRkQcsV5bGK2Zfk@mail.gmail.com Grazvydas Ignotas wrote:
This does not apply. This is probably because I added your other patches
Yeah this this was supposed to be applied instead of "OMAP3: pandora: remove unused config macros" (it covers pandora and other boards, you applied pandora-only version).
I see my email got mangled in u-boot-ti.git, could you fix it up if you haven't sent pull request yet? You could replace this patch with 2/3 along the way too (can be done easily with git rebase -i).
I think Grazvydas is right on both accounts. I dropped the pull from the -ti repo again and suggest you do the changes as suggested by Grazvydas. Is this OK with you?
Please send new pull request when you are ready.
Best regards,
Wolfgang Denk
Dear Sandeep,
In message AANLkTikYMeERp9JXSS71+4Uv+WD38zRkQcsV5bGK2Zfk@mail.gmail.com Grazvydas Ignotas wrote:
This does not apply. This is probably because I added your other
patches
Yeah this this was supposed to be applied instead of "OMAP3: pandora: remove unused config macros" (it covers pandora and other boards, you applied pandora-only version).
I see my email got mangled in u-boot-ti.git, could you fix it up if you haven't sent pull request yet? You could replace this patch with 2/3 along the way too (can be done easily with git rebase -i).
I think Grazvydas is right on both accounts. I dropped the pull from the -ti repo again and suggest you do the changes as suggested by Grazvydas. Is this OK with you?
Yes not problem
Please send new pull request when you are ready.
I just did
Regards, Sandeep
participants (3)
-
Grazvydas Ignotas -
Paulraj, Sandeep -
Wolfgang Denk