In message 41AB5DE0.1040402@applieddata.net you wrote:

This patch adds support for the ADSVIX SBC with PXA27x processor.

Mostly added.

Please provide a proper patch next time (CHANGELOG entry), and stick to the Coding Style (indentation by TAB, no trailing white space, etc.)

Here is what I rejected:

diff -urN u-boot/common/cmd_pcmcia.c u-boot.vix/common/cmd_pcmcia.c --- u-boot/common/cmd_pcmcia.c 2004-04-18 13:39:39.000000000 -0400 +++ u-boot.vix/common/cmd_pcmcia.c 2004-11-24 12:13:18.000000000 -0500 @@ -382,6 +382,11 @@

#endif /* EXADRON 1 */

+#ifdef CONFIG_ADSVIX + void pcmcia_power_on(void); + pcmcia_power_on(); +#endif + rc = check_ide_device (0); /* use just slot 0 */

return rc; @@ -445,6 +450,10 @@ #ifdef CONFIG_PXA_PCMCIA static int pcmcia_off (void) { +#ifdef CONFIG_ADSVIX + void pcmcia_power_off(void); + pcmcia_power_off(); +#endif return 0; } #endif

Please implement this in a board independent way, something like

#ifdef CONFIG_BOARD_PCMCIA_POWERON boardpcmcia_power_on(); #endif

or so.

diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile --- u-boot/examples/Makefile 2004-10-10 17:27:33.000000000 -0400 +++ u-boot.vix/examples/Makefile 2004-11-24 12:13:18.000000000 -0500 @@ -30,7 +30,11 @@ endif

ifeq ($(ARCH),arm) -LOAD_ADDR = 0xc100000 +ifeq ($(CPU),pxa) +LOAD_ADDR = 0xa1000000 +else +LOAD_ADDR = 0xc1000000 +endif endif

Please don't mess with other boards.

Best regards,

Wolfgang Denk