[PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz --- Dear Stefan, as with the network issue, could we get this to master ASAP? --- arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi index 2e05b973d2..28a36a6103 100644 --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi @@ -21,3 +21,7 @@ };
/delete-node/ &mdio; + +&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};
On 3/22/22 17:17, Marek Behún wrote:
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz
Reviewed-by: Stefan Roese sr@denx.de
Dear Stefan, as with the network issue, could we get this to master ASAP?
Sure. Let me try...
Thanks, Stefan
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi index 2e05b973d2..28a36a6103 100644 --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi @@ -21,3 +21,7 @@ };
/delete-node/ &mdio;
+&usb3 {
- vbus-supply = <&exp_usb3_vbus>;
+};
Viele Grüße, Stefan Roese
Added Tom to Cc.
On 3/23/22 06:55, Stefan Roese wrote:
On 3/22/22 17:17, Marek Behún wrote:
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz
Reviewed-by: Stefan Roese sr@denx.de
Dear Stefan, as with the network issue, could we get this to master ASAP?
Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot":
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=resu...
This should not result from this patch though.
Could you please pull this patch/fix directly?
Thanks, Stefan
Thanks, Stefan
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi index 2e05b973d2..28a36a6103 100644 --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi @@ -21,3 +21,7 @@ }; /delete-node/ &mdio;
+&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};
Viele Grüße, Stefan Roese
Viele Grüße, Stefan Roese
On Wed, Mar 23, 2022 at 07:46:40AM +0100, Stefan Roese wrote:
Added Tom to Cc.
On 3/23/22 06:55, Stefan Roese wrote:
On 3/22/22 17:17, Marek Behún wrote:
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz
Reviewed-by: Stefan Roese sr@denx.de
Dear Stefan, as with the network issue, could we get this to master ASAP?
Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot":
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=resu...
This should not result from this patch though.
Yes, Google is being funny for some reason, I just keep hitting retry until it passes.
Could you please pull this patch/fix directly?
OK.
On Tuesday 22 March 2022 17:17:59 Marek Behún wrote:
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz
Reviewed-by: Pali Rohár pali@kernel.org
Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another Armada 3720 board) and both are working fine in U-Boot. Therefore no USB fix is needed for Espressobin DTS file.
Dear Stefan, as with the network issue, could we get this to master ASAP?
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi index 2e05b973d2..28a36a6103 100644 --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi @@ -21,3 +21,7 @@ };
/delete-node/ &mdio;
+&usb3 {
- vbus-supply = <&exp_usb3_vbus>;
+};
2.34.1
On Tue, Mar 22, 2022 at 05:17:59PM +0100, Marek Behún wrote:
From: Marek Behún marek.behun@nic.cz
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a `phy-supply` property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") Signed-off-by: Marek Behún marek.behun@nic.cz Reviewed-by: Stefan Roese sr@denx.de
Applied to u-boot/master, thanks!
participants (4)
-
Marek Behún -
Pali Rohár -
Stefan Roese -
Tom Rini