[U-Boot-Users] [Patch] Make MPC8266ADS command selection more robust
Fix MPC8266 command line definition so it won't break when new commands are added to u-boot. Signed-off-by Rune Torgersen runet@innovsys.com
--- Even using the config_cmd_default, there are commands that needs to be undef'd, and if someone adds a command to the default set that doesn't compile on all targets, it will break agaim, but I guess it is better this way.
diff --git a/include/configs/MPC8266ADS.h b/include/configs/MPC8266ADS.h index d392b98..3659002 100644 --- a/include/configs/MPC8266ADS.h +++ b/include/configs/MPC8266ADS.h @@ -146,39 +146,26 @@ /* * Command line configuration. */ -#include <config_cmd_all.h> - -#undef CONFIG_CMD_BEDBUG -#undef CONFIG_CMD_BMP -#undef CONFIG_CMD_BSP -#undef CONFIG_CMD_DATE -#undef CONFIG_CMD_DHCP -#undef CONFIG_CMD_DISPLAY -#undef CONFIG_CMD_DOC -#undef CONFIG_CMD_DTT -#undef CONFIG_CMD_EEPROM -#undef CONFIG_CMD_ELF -#undef CONFIG_CMD_EXT2 -#undef CONFIG_CMD_FDC -#undef CONFIG_CMD_FDOS -#undef CONFIG_CMD_HWFLOW -#undef CONFIG_CMD_IDE -#undef CONFIG_CMD_JFFS2 -#undef CONFIG_CMD_KGDB -#undef CONFIG_CMD_MFSL -#undef CONFIG_CMD_MMC -#undef CONFIG_CMD_NAND -#undef CONFIG_CMD_ONENAND -#undef CONFIG_CMD_PCMCIA -#undef CONFIG_CMD_REISER -#undef CONFIG_CMD_SCSI -#undef CONFIG_CMD_SPI -#undef CONFIG_CMD_SNTP -#undef CONFIG_CMD_VFD -#undef CONFIG_CMD_UNIVERSE -#undef CONFIG_CMD_USB -#undef CONFIG_CMD_XIMG -#undef CONFIG_CMD_AT91_SPIMUX +#include <config_cmd_default.h> + +/* Commands we want, that are not part of default set */ +#define CONFIG_CMD_ASKENV /* ask for env variable */ +#define CONFIG_CMD_CACHE /* icache, dcache */ +#define CONFIG_CMD_DHCP /* DHCP Support */ +#define CONFIG_CMD_DIAG /* Diagnostics */ +#define CONFIG_CMD_IMMAP /* IMMR dump support */ +#define CONFIG_CMD_IRQ /* irqinfo */ +#define CONFIG_CMD_MII /* MII support */ +#define CONFIG_CMD_PCI /* pciinfo */ +#define CONFIG_CMD_PING /* ping support */ +#define CONFIG_CMD_PORTIO /* Port I/O */ +#define CONFIG_CMD_REGINFO /* Register dump */ +#define CONFIG_CMD_SAVES /* save S record dump */ +#define CONFIG_CMD_SDRAM /* SDRAM DIMM SPD info printout */ + +/* Commands from default set we don't need */ +#undef CONFIG_CMD_FPGA /* FPGA configuration Support */ +#undef CONFIG_CMD_SETGETDCR /* DCR support on 4xx */
/* Define a command string that is automatically executed when no character * is read on the console interface withing "Boot Delay" after reset.
Rune Torgersen wrote:
Fix MPC8266 command line definition so it won't break when new commands are added to u-boot. Signed-off-by Rune Torgersen runet@innovsys.com
Even using the config_cmd_default, there are commands that needs to be undef'd, and if someone adds a command to the default set that doesn't compile on all targets, it will break agaim, but I guess it is better this way.
HEY, whining DOES work. I wonder what else my mother lied about??? :-)
Thanks, Rune! gvb
On Wed, 2007-10-17 at 11:56, Rune Torgersen wrote:
Even using the config_cmd_default, there are commands that needs to be undef'd, and if someone adds a command to the default set that doesn't compile on all targets, it will break agaim, but I guess it is better this way.
Remember, the longer term plan is to convert this to an explicit list of enabled options in a per-board default Kconfig options file. That approach will not have these same issues, so what you describe above will not be a problem in the long run!
Thanks, jdl
In message 47163ebf.fJp0E13KipkTuTx5%runet@innovsys.com you wrote:
Fix MPC8266 command line definition so it won't break when new commands are added to u-boot. Signed-off-by Rune Torgersen runet@innovsys.com
Applied, thanks.
Even using the config_cmd_default, there are commands that needs to be undef'd, and if someone adds a command to the default set that doesn't compile on all targets, it will break agaim, but I guess it is better this way.
I agree. Thanks.
Best regards,
Wolfgang Denk
participants (4)
-
Jerry Van Baren -
Jon Loeliger -
Rune Torgersen -
Wolfgang Denk