[U-Boot-Users] [PATCH] Total5100 and Total5200 platform support
Hello,
attached you'll find a patch which adds support for the Total5100 (MGT5100 processor) and Total5200 (MPC5200) platforms from Freescale. The port is based on the Icecube (Lite5200) and supports like it I2C, ATA and USB. The Flash is accessed using the generic CFI routines.
Regards Mark
* Patch by Mark Jonas, 01 July 2004: Added support for Total5100 and Total5200 (Rev.1 and Rev.2) MGT5100 and MPC5200 based Freescale platforms.
CREDITS | 5 MAKEALL | 1 Makefile | 28 ++ board/total5200/Makefile | 46 ++++ board/total5200/config.mk | 43 ++++ board/total5200/mt48lc16m16a2-75.h | 43 ++++ board/total5200/mt48lc32m16a2-75.h | 40 +++ board/total5200/sdram.c | 227 +++++++++++++++++++++ board/total5200/sdram.h | 39 +++ board/total5200/total5200.c | 136 ++++++++++++ board/total5200/u-boot.lds | 122 +++++++++++ cpu/mpc5xxx/fec.c | 8 cpu/mpc5xxx/ide.c | 6 cpu/mpc5xxx/start.S | 3 include/configs/Total5200.h | 390 +++++++++++++++++++++++++++++++++++++ include/mpc5xxx.h | 17 + 16 files changed, 1154 insertions(+)
Hello,
the attached patch adds support for the Total5100's and Total5200's LCD screen. By default only the logo is displayed because the environment variable "console" is set to "serial". By clearing this variable stdout and stderr will be displayed on the LCD. The patch should be applied after the initial (20040701) and the second patch (20040702).
Regards Mark
Hello, attached you'll find a patch which adds support for the Total5100 (MGT5100 processor) and Total5200 (MPC5200) platforms from Freescale. The port is based on the Icecube (Lite5200) and supports like it I2C, ATA and USB. The Flash is accessed using the generic CFI routines. Regards Mark
- Patch by Mark Jonas, 01 July 2004:
Added support for Total5100 and Total5200 (Rev.1 and Rev.2) MGT5100 and MPC5200 based Freescale platforms.
CREDITS | 5 MAKEALL | 1 Makefile | 28 ++ board/total5200/Makefile | 46 ++++ board/total5200/config.mk | 43 ++++ board/total5200/mt48lc16m16a2-75.h | 43 ++++ board/total5200/mt48lc32m16a2-75.h | 40 +++ board/total5200/sdram.c | 227 +++++++++++++++++++++ board/total5200/sdram.h | 39 +++ board/total5200/total5200.c | 136 ++++++++++++ board/total5200/u-boot.lds | 122 +++++++++++ cpu/mpc5xxx/fec.c | 8 cpu/mpc5xxx/ide.c | 6 cpu/mpc5xxx/start.S | 3 include/configs/Total5200.h | 390 +++++++++++++++++++++++++++++++++++++ include/mpc5xxx.h | 17 + 16 files changed, 1154 insertions(+)
board/total5200/total5200.c | 174 ++++++++++++++++++++++++++++++++++++++++++++ drivers/cfb_console.c | 7 + include/configs/Total5200.h | 27 ++++++ 3 files changed, 202 insertions(+), 6 deletions(-)
In message 40E95290.3040607@freescale.com you wrote:
the attached patch adds support for the Total5100's and Total5200's LCD screen. By default only the logo is displayed because the environment variable "console" is set to "serial". By clearing this variable stdout and stderr will be displayed on the LCD. The patch should be applied after the initial (20040701) and the second patch (20040702).
Can you please fix this patch to use the standard console device mechanism of U-Boot? Instead of introducing a new "console" variable. the standard mechanism of assigning to the stdin / stdout / stderr streams should be used.
I just learned that there are already other bad examples using such a "console" setting:
File: Board: Maintainer: board/eltec/elppc/misc.c ELPPC Frank Gottschling board/netphone/phone_console.c NETPHONE Pantelis Antoniou drivers/cfb_console.c ? Frank Gottschling
Frank & Pantelis, can you please submit patches to clean this up, too? Let's get rid of this "console" stuff before anybody else copies it. [Sorry that this escaped me so far.]
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
In message 40E95290.3040607@freescale.com you wrote:
the attached patch adds support for the Total5100's and Total5200's LCD screen. By default only the logo is displayed because the environment variable "console" is set to "serial". By clearing this variable stdout and stderr will be displayed on the LCD. The patch should be applied after the initial (20040701) and the second patch (20040702).
Can you please fix this patch to use the standard console device mechanism of U-Boot? Instead of introducing a new "console" variable. the standard mechanism of assigning to the stdin / stdout / stderr streams should be used.
I just learned that there are already other bad examples using such a "console" setting:
File: Board: Maintainer: board/eltec/elppc/misc.c ELPPC Frank Gottschling board/netphone/phone_console.c NETPHONE Pantelis Antoniou drivers/cfb_console.c ? Frank Gottschling
Frank & Pantelis, can you please submit patches to clean this up, too? Let's get rid of this "console" stuff before anybody else copies it. [Sorry that this escaped me so far.]
Best regards,
Wolfgang Denk
Excuse me Wolfgang but what is the problem?
In my board I don't use an extra console variable. I just wait for a key sequence to enable the lcd console which does use the standard u-boot mechanism.
Have I missed something here?
Regards
Pantelis
Dear Pantelis,
in message 40EA413B.1000407@intracom.gr you wrote:
I just learned that there are already other bad examples using such a "console" setting:
File: Board: Maintainer: board/eltec/elppc/misc.c ELPPC Frank Gottschling board/netphone/phone_console.c NETPHONE Pantelis Antoniou drivers/cfb_console.c ? Frank Gottschling
...
Excuse me Wolfgang but what is the problem?
The problem is that the files listed above invented a new, non-standard mechanism for something which is already available and thus should be done in a different way.
In my board I don't use an extra console variable. I just wait for a key sequence to enable the lcd console which does use the standard u-boot mechanism.
Have I missed something here?
See "board/netphone/phone_console.c":
... 331 /* 332 * Force console i/o to serial ? 333 */ 334 if ((penv = getenv("console")) != NULL && strcmp(penv, "serial") == 0) 335 return 0; ...
Here you _do_ use an extra console variable.
Please get rid of this. Please the standard stdin / stdout / stderr (here probably stdout) settings for this.
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
Dear Pantelis,
in message 40EA413B.1000407@intracom.gr you wrote:
I just learned that there are already other bad examples using such a "console" setting:
File: Board: Maintainer: board/eltec/elppc/misc.c ELPPC Frank Gottschling board/netphone/phone_console.c NETPHONE Pantelis Antoniou drivers/cfb_console.c ? Frank Gottschling
...
Excuse me Wolfgang but what is the problem?
The problem is that the files listed above invented a new, non-standard mechanism for something which is already available and thus should be done in a different way.
In my board I don't use an extra console variable. I just wait for a key sequence to enable the lcd console which does use the standard u-boot mechanism.
Have I missed something here?
See "board/netphone/phone_console.c":
... 331 /* 332 * Force console i/o to serial ? 333 */ 334 if ((penv = getenv("console")) != NULL && strcmp(penv, "serial") == 0) 335 return 0; ...
Here you _do_ use an extra console variable.
Oops, you're correct.
I have forgotten about this because I don't actually use it anywhere.
Attached patch just kills this.
Please get rid of this. Please the standard stdin / stdout / stderr (here probably stdout) settings for this.
Best regards,
Wolfgang Denk
Regards
Pantelis
In message 40E4316A.5040604@freescale.com you wrote:
attached you'll find a patch which adds support for the Total5100 (MGT5100 processor) and Total5200 (MPC5200) platforms from Freescale. The port is based on the Icecube (Lite5200) and supports like it I2C, ATA and USB. The Flash is accessed using the generic CFI routines.
Added, thanks. Please don't add trailing white space.
Best regards,
Wolfgang Denk
participants (3)
-
Mark Jonas -
Pantelis Antoniou -
Wolfgang Denk